-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Remove sizzle expando after clone action #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Jogi: i'm trying to reproduce my case correctly ... |
Your examples seem to be working correctly. Can you describe what you're trying to do, what behavior you're expecting, and what behavior you're seeing? |
Jogi: 0k So there is my case: I don't understand why on IE8: $("#tblMF .numasaCmp_1 [name='NUMASA_CMP']") => undefined but $("#tblMF .numasaCmp_1").find("[name='NUMASA_CMP']") => works On Firefox, both works. |
We'll need something more reduced than 1.4 KB of HTML plus a script unrelated to this issue. |
Jogi: i See one more thing, if i remove the line with .prop("disabled", false) , my selector works correclty. |
Jogi: other observation: $("#tblMF .numasaCmp_1 [name='NUMASA_CMP']") => undefined but $("#tblAA .numasaCmp_1 [name='NUMASA_CMP']") => work |
I removed superfluous markup and script from your fiddle and changed There is something to this that seems to be related to Sizzle combinator caching in oldIE. |
Jogi: Same problem with ":input" instead of [name...] |
This is actually a problem with .clone: http://jsfiddle.net/JTtu3/59/ In IE8 (and other versions as well, I'm sure), the clone still has a reference to the Sizzle cache object of its referent, which wreaks all kinds of havoc with any operation using it. Maybe we can update fixCloneNodeIssues to look for and remove attributes associated with reference-equal clone/source properties. |
PR: #1652 |
Per the discussion on gh-1652 we decided there was no good solution but the least bad solution was that we'd clear the Sizzle expando. Is that correct? |
Correct. |
@gibson042 please ping me up when you gonna update sizzle |
Testing changes Ref jquery/jquery#1709
Originally reported by Jogi: http://bugs.jquery.com/ticket/15104
Issue with space in selector with jquery 1.11.1 and Internet explorer.
exemple:
$(".testCls [name='blabla']")
cannot find anything when with older version, it work.
jsfiddle: http://jsfiddle.net/kwfHZ/1/
The text was updated successfully, but these errors were encountered: