-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jquery/jquery
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7a0a850
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jquery/jquery
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e1cffde
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 13 commits
- 18 files changed
- 5 contributors
Commits on Apr 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 898784a - Browse repository at this point
Copy the full SHA 898784aView commit details
Commits on Apr 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 763dd3f - Browse repository at this point
Copy the full SHA 763dd3fView commit details
Commits on Apr 20, 2020
-
Data: Make the data object a regular object again
The change in gh-4603 made the object returned by `elem.data()` a prototype-less object. That's a desired change to support keys colliding with `Object.prototype` properties but it's also a breaking change so it has to wait for jQuery 4.0.0. A 3.x-only test was added to avoid breaking it in the future on this branch. Fixes gh-4665 Ref gh-4603 Closes gh-4666
4Configuration menu - View commit details
-
Copy full SHA for 65e9098 - Browse repository at this point
Copy the full SHA 65e9098View commit details -
Configuration menu - View commit details
-
Copy full SHA for b21d671 - Browse repository at this point
Copy the full SHA b21d671View commit details
Commits on Apr 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 205dd13 - Browse repository at this point
Copy the full SHA 205dd13View commit details
Commits on Apr 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f7fed7e - Browse repository at this point
Copy the full SHA f7fed7eView commit details
Commits on Apr 27, 2020
-
Tests: Fix flakiness in the "jQuery.ajax() - JSONP - Same Domain" test
The "jQuery.ajax() - JSONP - Same Domain" test is firing a request with a duplicate "callback" parameter, something like (simplified): ``` mock.php?action=jsonp&callback=jQuery_1&callback=jQuery_2 ``` There was a difference in how the PHP & Node.js implementations of the jsonp action in the mock server handled situations like that. The PHP implementation was using the latest parameter while the Node.js one was turning it into an array but the code didn't handle this situation. Because of how JavaScript stringifies arrays, while the PHP implementation injected the following code: ```js jQuery_2(payload) ``` the Node.js one was injecting the following one: ```js jQuery_1,jQuery_2(payload) ``` This is a comma expression in JavaScript; it so turned out that in the majority of cases both callbacks were identical so it was more like: ```js jQuery_1,jQuery_1(payload) ``` which evaluates to `jQuery_1(payload)` when `jQuery_1` is defined, making the test go as expected. In many cases, though, especially on Travis, the callbacks were different, triggering an `Uncaught ReferenceError` error & requiring frequent manual re-runs of Travis builds. This commit fixes the logic in the mock Node.js server, adding special handling for arrays. Closes gh-4687 (cherry picked from commit 7b0864d)
Configuration menu - View commit details
-
Copy full SHA for 46ba70c - Browse repository at this point
Copy the full SHA 46ba70cView commit details -
Tests: Cleanup
window
&document
handlers in a new event testThe "focusin on document & window" test didn't cleanup `focusout` handlers on `window` & `document`. This has been fixed. Ref gh-4657
Configuration menu - View commit details
-
Copy full SHA for c1c0598 - Browse repository at this point
Copy the full SHA c1c0598View commit details
Commits on Apr 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 58a8e87 - Browse repository at this point
Copy the full SHA 58a8e87View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea3766c - Browse repository at this point
Copy the full SHA ea3766cView commit details
Commits on Apr 30, 2020
-
Tests: Workaround failures in recent XSS tests in iOS 8 - 12
Configuration menu - View commit details
-
Copy full SHA for ea2d0d5 - Browse repository at this point
Copy the full SHA ea2d0d5View commit details
Commits on May 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7d2ce69 - Browse repository at this point
Copy the full SHA 7d2ce69View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1cffde - Browse repository at this point
Copy the full SHA e1cffdeView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7a0a850...e1cffde