Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jquery/jquery
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7a0a850
Choose a base ref
...
head repository: jquery/jquery
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e1cffde
Choose a head ref
  • 13 commits
  • 18 files changed
  • 5 contributors

Commits on Apr 10, 2020

  1. Copy the full SHA
    898784a View commit details

Commits on Apr 17, 2020

  1. Docs: Use https for hyperlinks in README

    Closes gh-4673
    
    (cherry picked from commit 73415da)
    vanillajonathan authored and mgol committed Apr 17, 2020
    Copy the full SHA
    763dd3f View commit details

Commits on Apr 20, 2020

  1. Data: Make the data object a regular object again

    The change in gh-4603 made the object returned by `elem.data()`
    a prototype-less object. That's a desired change to support keys
    colliding with `Object.prototype` properties but it's also a breaking
    change so it has to wait for jQuery 4.0.0.
    
    A 3.x-only test was added to avoid breaking it in the future on this
    branch.
    
    Fixes gh-4665
    Ref gh-4603
    Closes gh-4666
    mgol authored Apr 20, 2020
    4
    Copy the full SHA
    65e9098 View commit details
  2. Build: Enable reportUnusedDisableDirectives in ESLint

    This forbids unnecessary `eslint-disable` comments.
    
    Ref gh-4095
    Closes gh-4520
    
    (cherry picked from 46f9810)
    edg2s authored and mgol committed Apr 20, 2020
    Copy the full SHA
    b21d671 View commit details

Commits on Apr 23, 2020

  1. Build: Test on Node.js 14, stop testing on Node.js 8 & 13

    Closes gh-4678
    
    (cherry picked from commit 88eb22e)
    mgol committed Apr 23, 2020
    Copy the full SHA
    205dd13 View commit details

Commits on Apr 25, 2020

  1. Docs: Update the link to the jsdom repository

    Closes gh-4684
    
    (cherry picked from commit a62309e)
    mgol committed Apr 25, 2020
    Copy the full SHA
    f7fed7e View commit details

Commits on Apr 27, 2020

  1. Tests: Fix flakiness in the "jQuery.ajax() - JSONP - Same Domain" test

    The "jQuery.ajax() - JSONP - Same Domain" test is firing a request with
    a duplicate "callback" parameter, something like (simplified):
    ```
    mock.php?action=jsonp&callback=jQuery_1&callback=jQuery_2
    ```
    
    There was a difference in how the PHP & Node.js implementations of the jsonp
    action in the mock server handled situations like that. The PHP implementation
    was using the latest parameter while the Node.js one was turning it into an
    array but the code didn't handle this situation. Because of how JavaScript
    stringifies arrays, while the PHP implementation injected the following code:
    ```js
    jQuery_2(payload)
    ```
    the Node.js one was injecting the following one:
    ```js
    jQuery_1,jQuery_2(payload)
    ```
    This is a comma expression in JavaScript; it so turned out that in the majority
    of cases both callbacks were identical so it was more like:
    ```js
    jQuery_1,jQuery_1(payload)
    ```
    which evaluates to `jQuery_1(payload)` when `jQuery_1` is defined, making the
    test go as expected. In many cases, though, especially on Travis, the callbacks
    were different, triggering an `Uncaught ReferenceError` error & requiring
    frequent manual re-runs of Travis builds.
    
    This commit fixes the logic in the mock Node.js server, adding special handling
    for arrays.
    
    Closes gh-4687
    
    (cherry picked from commit 7b0864d)
    mgol committed Apr 27, 2020
    Copy the full SHA
    46ba70c View commit details
  2. Tests: Cleanup window & document handlers in a new event test

    The "focusin on document & window" test didn't cleanup `focusout` handlers
    on `window` & `document`. This has been fixed.
    
    Ref gh-4657
    mgol committed Apr 27, 2020
    Copy the full SHA
    c1c0598 View commit details

Commits on Apr 29, 2020

  1. Tests: Add tests for recently fixed manipulation XSS issues

    Closes gh-4685
    Ref gh-4642
    Ref gh-4647
    
    (cherry picked from commit dc06d68)
    mgol committed Apr 29, 2020
    Copy the full SHA
    58a8e87 View commit details
  2. Docs: Fix typos

    Closes gh-4686
    
    (cherry picked from commit 1a7332c)
    pgrimaud authored and mgol committed Apr 29, 2020
    Copy the full SHA
    ea3766c View commit details

Commits on Apr 30, 2020

  1. Tests: Workaround failures in recent XSS tests in iOS 8 - 12

    iOS 8-12 parses `<noembed>` tags differently, executing this code. This is no
    different to native behavior on that OS, though, so just accept it.
    
    Ref gh-4685
    Closes gh-4694
    
    (cherry picked from commit 11066a9)
    mgol committed Apr 30, 2020
    Copy the full SHA
    ea2d0d5 View commit details

Commits on May 4, 2020

  1. Release: update AUTHORS.txt

    timmywil committed May 4, 2020
    Copy the full SHA
    7d2ce69 View commit details
  2. 3.5.1

    timmywil committed May 4, 2020
    Copy the full SHA
    e1cffde View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff 7a0a850...e1cffde