Skip to content

Commit ad3c2ef

Browse files
committedOct 22, 2019
Build: Run tests on Travis on FirefoxHeadless as well
Also, run them on both ChromeHeadless & FirefoxHeadless locally on `grunt karma:main`. Plus, so far, the chrome addons were installed for all the jobs, even the ones that weren't used for browser testing. Changing that makes those jobs faster. (cherry-picked from 84835e68239ce55d1fc007b284e8ef4ed2817c2)
1 parent 57038fa commit ad3c2ef

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed
 

Diff for: ‎.travis.yml

+7-4
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,17 @@ node_js:
44
- "8"
55
- "10"
66
- "12"
7-
addons:
8-
chrome: stable
97
env:
108
- NPM_SCRIPT=test:browserless
119
matrix:
1210
include:
1311
# Run browser tests only on one Node.js version to save time.
14-
- node_js: "10"
15-
env: NPM_SCRIPT=test:browser
12+
- node_js: "12"
13+
env:
14+
- NPM_SCRIPT="test:browser"
15+
- BROWSERS="ChromeHeadless,FirefoxHeadless"
16+
addons:
17+
chrome: stable
18+
firefox: latest
1619
script:
1720
- npm run $NPM_SCRIPT

Diff for: ‎Gruntfile.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ module.exports = function( grunt ) {
1414

1515
var fs = require( "fs" ),
1616
gzip = require( "gzip-js" ),
17-
isTravis = process.env.TRAVIS,
1817
oldNode = /^v6\./.test( process.version );
1918

2019
// Support: Node.js <8
@@ -223,9 +222,7 @@ module.exports = function( grunt ) {
223222
singleRun: true
224223
},
225224
main: {
226-
227-
// The Chrome sandbox doesn't work on Travis.
228-
browsers: [ isTravis ? "ChromeHeadlessNoSandbox" : "ChromeHeadless" ]
225+
browsers: [ "ChromeHeadless", "FirefoxHeadless" ]
229226
},
230227

231228
jsdom: {

0 commit comments

Comments
 (0)