Skip to content

Commit 95e34b6

Browse files
mgolmgol
authored
Docs: Replace #NUMBER Trac issue references with trac-NUMBER
This is a version of gh-4993 for the `3.x-stable` branch. The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing when in jQuery source it's usually referring to the old deprecated Trac instance at https://bugs.jquery.com. This change replaces all such Trac references with `trac-NUMBER`. A few of the references came with the Sizzle integration and referred to the Sizzle GitHub bug tracker. Those have been replaced with full links instead. A new entry describing issue reference conventions has been added to README. Closes gh-4994 Ref gh-4993 Ref 5d5ea01
1 parent fa70e8f commit 95e34b6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+404
-398
lines changed

‎README.md

+6
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ In the spirit of open source software development, jQuery always encourages comm
1414
2. [Core Style Guide](https://contribute.jquery.org/style-guide/js/)
1515
3. [Writing Code for jQuery Foundation Projects](https://contribute.jquery.org/code/)
1616

17+
### References to issues/PRs
18+
19+
GitHub issues/PRs are usually referenced via `gh-NUMBER`, where `NUMBER` is the numerical ID of the issue/PR. You can find such an issue/PR under `https://github.com/jquery/jquery/issues/NUMBER`.
20+
21+
jQuery has used a different bug tracker - based on Trac - in the past, available under [bugs.jquery.com](https://bugs.jquery.com/). It is being kept in read only mode so that referring to past discussions is possible. When jQuery source references one of those issues, it uses the pattern `trac-NUMBER`, where `NUMBER` is the numerical ID of the issue. You can find such an issue under `https://bugs.jquery.com/ticket/NUMBER`.
22+
1723

1824
Environments in which to use jQuery
1925
--------------------------------------

‎src/ajax.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ var
2222
rantiCache = /([?&])_=[^&]*/,
2323
rheaders = /^(.*?):[ \t]*([^\r\n]*)$/mg,
2424

25-
// #7653, #8125, #8152: local protocol detection
25+
// trac-7653, trac-8125, trac-8152: local protocol detection
2626
rlocalProtocol = /^(?:about|app|app-storage|.+-extension|file|res|widget):$/,
2727
rnoContent = /^(?:GET|HEAD)$/,
2828
rprotocol = /^\/\//,
@@ -45,7 +45,7 @@ var
4545
*/
4646
transports = {},
4747

48-
// Avoid comment-prolog char sequence (#10098); must appease lint and evade compression
48+
// Avoid comment-prolog char sequence (trac-10098); must appease lint and evade compression
4949
allTypes = "*/".concat( "*" ),
5050

5151
// Anchor tag for parsing the document origin
@@ -116,7 +116,7 @@ function inspectPrefiltersOrTransports( structure, options, originalOptions, jqX
116116

117117
// A special extend for ajax options
118118
// that takes "flat" options (not to be deep extended)
119-
// Fixes #9887
119+
// Fixes trac-9887
120120
function ajaxExtend( target, src ) {
121121
var key, deep,
122122
flatOptions = jQuery.ajaxSettings.flatOptions || {};
@@ -527,12 +527,12 @@ jQuery.extend( {
527527
deferred.promise( jqXHR );
528528

529529
// Add protocol if not provided (prefilters might expect it)
530-
// Handle falsy url in the settings object (#10093: consistency with old signature)
530+
// Handle falsy url in the settings object (trac-10093: consistency with old signature)
531531
// We also use the url parameter if available
532532
s.url = ( ( url || s.url || location.href ) + "" )
533533
.replace( rprotocol, location.protocol + "//" );
534534

535-
// Alias method option to type as per ticket #12004
535+
// Alias method option to type as per ticket trac-12004
536536
s.type = options.method || options.type || s.method || s.type;
537537

538538
// Extract dataTypes list
@@ -575,7 +575,7 @@ jQuery.extend( {
575575
}
576576

577577
// We can fire global events as of now if asked to
578-
// Don't fire events if jQuery.event is undefined in an AMD-usage scenario (#15118)
578+
// Don't fire events if jQuery.event is undefined in an AMD-usage scenario (trac-15118)
579579
fireGlobals = jQuery.event && s.global;
580580

581581
// Watch for a new set of requests
@@ -604,7 +604,7 @@ jQuery.extend( {
604604
if ( s.data && ( s.processData || typeof s.data === "string" ) ) {
605605
cacheURL += ( rquery.test( cacheURL ) ? "&" : "?" ) + s.data;
606606

607-
// #9682: remove data so that it's not used in an eventual retry
607+
// trac-9682: remove data so that it's not used in an eventual retry
608608
delete s.data;
609609
}
610610

‎src/ajax/xhr.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var xhrSuccessStatus = {
1818
0: 200,
1919

2020
// Support: IE <=9 only
21-
// #1450: sometimes IE returns 1223 when it should be 204
21+
// trac-1450: sometimes IE returns 1223 when it should be 204
2222
1223: 204
2323
},
2424
xhrSupported = jQuery.ajaxSettings.xhr();
@@ -90,7 +90,7 @@ jQuery.ajaxTransport( function( options ) {
9090
} else {
9191
complete(
9292

93-
// File: protocol always yields status 0; see #8605, #14207
93+
// File: protocol always yields status 0; see trac-8605, trac-14207
9494
xhr.status,
9595
xhr.statusText
9696
);
@@ -151,7 +151,7 @@ jQuery.ajaxTransport( function( options ) {
151151
xhr.send( options.hasContent && options.data || null );
152152
} catch ( e ) {
153153

154-
// #14683: Only rethrow if this hasn't been notified as an error yet
154+
// trac-14683: Only rethrow if this hasn't been notified as an error yet
155155
if ( callback ) {
156156
throw e;
157157
}

‎src/attributes/prop.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jQuery.extend( {
6262
// Support: IE <=9 - 11 only
6363
// elem.tabIndex doesn't always return the
6464
// correct value when it hasn't been explicitly set
65-
// Use proper attribute retrieval(#12072)
65+
// Use proper attribute retrieval (trac-12072)
6666
var tabindex = jQuery.find.attr( elem, "tabindex" );
6767

6868
if ( tabindex ) {

‎src/attributes/val.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jQuery.extend( {
9191
val :
9292

9393
// Support: IE <=10 - 11 only
94-
// option.text throws exceptions (#14686, #14858)
94+
// option.text throws exceptions (trac-14686, trac-14858)
9595
// Strip and collapse whitespace
9696
// https://html.spec.whatwg.org/#strip-and-collapse-whitespace
9797
stripAndCollapse( jQuery.text( elem ) );
@@ -118,7 +118,7 @@ jQuery.extend( {
118118
option = options[ i ];
119119

120120
// Support: IE <=9 only
121-
// IE8-9 doesn't update selected after form reset (#2551)
121+
// IE8-9 doesn't update selected after form reset (trac-2551)
122122
if ( ( option.selected || i === index ) &&
123123

124124
// Don't return options that are disabled or in a disabled optgroup

‎src/core/camelCase.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function fcamelCase( _all, letter ) {
1313

1414
// Convert dashed to camelCase; used by the css and data modules
1515
// Support: IE <=9 - 11, Edge 12 - 15
16-
// Microsoft forgot to hump their vendor prefix (#9572)
16+
// Microsoft forgot to hump their vendor prefix (trac-9572)
1717
function camelCase( string ) {
1818
return string.replace( rmsPrefix, "ms-" ).replace( rdashAlpha, fcamelCase );
1919
}

‎src/core/init.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ define( [
1414
var rootjQuery,
1515

1616
// A simple way to check for HTML strings
17-
// Prioritize #id over <tag> to avoid XSS via location.hash (#9521)
18-
// Strict HTML recognition (#11290: must start with <)
17+
// Prioritize #id over <tag> to avoid XSS via location.hash (trac-9521)
18+
// Strict HTML recognition (trac-11290: must start with <)
1919
// Shortcut simple #id case for speed
2020
rquickExpr = /^(?:\s*(<[\w\W]+>)[^>]*|#([\w-]+))$/,
2121

‎src/core/ready-no-deferred.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jQuery.extend( {
3030
isReady: false,
3131

3232
// A counter to track how many items to wait for before
33-
// the ready event fires. See #6781
33+
// the ready event fires. See trac-6781
3434
readyWait: 1,
3535

3636
ready: function( wait ) {

‎src/core/ready.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jQuery.extend( {
3131
isReady: false,
3232

3333
// A counter to track how many items to wait for before
34-
// the ready event fires. See #6781
34+
// the ready event fires. See trac-6781
3535
readyWait: 1,
3636

3737
// Handle when the DOM is ready

‎src/css.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -265,15 +265,15 @@ jQuery.extend( {
265265
if ( value !== undefined ) {
266266
type = typeof value;
267267

268-
// Convert "+=" or "-=" to relative numbers (#7345)
268+
// Convert "+=" or "-=" to relative numbers (trac-7345)
269269
if ( type === "string" && ( ret = rcssNum.exec( value ) ) && ret[ 1 ] ) {
270270
value = adjustCSS( elem, name, ret );
271271

272-
// Fixes bug #9237
272+
// Fixes bug trac-9237
273273
type = "number";
274274
}
275275

276-
// Make sure that null and NaN values aren't set (#7116)
276+
// Make sure that null and NaN values aren't set (trac-7116)
277277
if ( value == null || value !== value ) {
278278
return;
279279
}

‎src/css/curCSS.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ function curCSS( elem, name, computed ) {
2525
computed = computed || getStyles( elem );
2626

2727
// getPropertyValue is needed for:
28-
// .css('filter') (IE 9 only, #12537)
29-
// .css('--customProperty) (#3144)
28+
// .css('filter') (IE 9 only, trac-12537)
29+
// .css('--customProperty) (gh-3144)
3030
if ( computed ) {
3131
ret = computed.getPropertyValue( name ) || computed[ name ];
3232

‎src/css/support.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ define( [
7070
}
7171

7272
// Support: IE <=9 - 11 only
73-
// Style of cloned element affects source element cloned (#8908)
73+
// Style of cloned element affects source element cloned (trac-8908)
7474
div.style.backgroundClip = "content-box";
7575
div.cloneNode( true ).style.backgroundClip = "";
7676
support.clearCloneStyle = div.style.backgroundClip === "content-box";

‎src/css/var/getStyles.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ define( function() {
33

44
return function( elem ) {
55

6-
// Support: IE <=11 only, Firefox <=30 (#15098, #14150)
6+
// Support: IE <=11 only, Firefox <=30 (trac-15098, trac-14150)
77
// IE throws on elements created in popups
88
// FF meanwhile throws on frame elements through "defaultView.getComputedStyle"
99
var view = elem.ownerDocument.defaultView;

‎src/data.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ jQuery.fn.extend( {
109109
while ( i-- ) {
110110

111111
// Support: IE 11 only
112-
// The attrs elements can be null (#14894)
112+
// The attrs elements can be null (trac-14894)
113113
if ( attrs[ i ] ) {
114114
name = attrs[ i ].name;
115115
if ( name.indexOf( "data-" ) === 0 ) {

‎src/data/Data.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Data.prototype = {
2525
value = {};
2626

2727
// We can accept data for non-element nodes in modern browsers,
28-
// but we should not, see #8335.
28+
// but we should not, see trac-8335.
2929
// Always return an empty object.
3030
if ( acceptData( owner ) ) {
3131

‎src/effects.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ function Animation( elem, properties, options ) {
310310
remaining = Math.max( 0, animation.startTime + animation.duration - currentTime ),
311311

312312
// Support: Android 2.3 only
313-
// Archaic crash bug won't allow us to use `1 - ( 0.5 || 0 )` (#12497)
313+
// Archaic crash bug won't allow us to use `1 - ( 0.5 || 0 )` (trac-12497)
314314
temp = remaining / animation.duration || 0,
315315
percent = 1 - temp,
316316
index = 0,

‎src/event.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -393,15 +393,15 @@ jQuery.event = {
393393

394394
for ( ; cur !== this; cur = cur.parentNode || this ) {
395395

396-
// Don't check non-elements (#13208)
397-
// Don't process clicks on disabled elements (#6911, #8165, #11382, #11764)
396+
// Don't check non-elements (trac-13208)
397+
// Don't process clicks on disabled elements (trac-6911, trac-8165, trac-11382, trac-11764)
398398
if ( cur.nodeType === 1 && !( event.type === "click" && cur.disabled === true ) ) {
399399
matchedHandlers = [];
400400
matchedSelectors = {};
401401
for ( i = 0; i < delegateCount; i++ ) {
402402
handleObj = handlers[ i ];
403403

404-
// Don't conflict with Object.prototype properties (#13203)
404+
// Don't conflict with Object.prototype properties (trac-13203)
405405
sel = handleObj.selector + " ";
406406

407407
if ( matchedSelectors[ sel ] === undefined ) {
@@ -655,7 +655,7 @@ jQuery.Event = function( src, props ) {
655655

656656
// Create target properties
657657
// Support: Safari <=6 - 7 only
658-
// Target should not be a text node (#504, #13143)
658+
// Target should not be a text node (trac-504, trac-13143)
659659
this.target = ( src.target && src.target.nodeType === 3 ) ?
660660
src.target.parentNode :
661661
src.target;

‎src/event/trigger.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ jQuery.extend( jQuery.event, {
7575
return;
7676
}
7777

78-
// Determine event propagation path in advance, per W3C events spec (#9951)
79-
// Bubble up to document, then to window; watch for a global ownerDocument var (#9724)
78+
// Determine event propagation path in advance, per W3C events spec (trac-9951)
79+
// Bubble up to document, then to window; watch for a global ownerDocument var (trac-9724)
8080
if ( !onlyHandlers && !special.noBubble && !isWindow( elem ) ) {
8181

8282
bubbleType = special.delegateType || type;
@@ -128,7 +128,7 @@ jQuery.extend( jQuery.event, {
128128
acceptData( elem ) ) {
129129

130130
// Call a native DOM method on the target with the same name as the event.
131-
// Don't do default actions on window, that's where global variables be (#6170)
131+
// Don't do default actions on window, that's where global variables be (trac-6170)
132132
if ( ontype && isFunction( elem[ type ] ) && !isWindow( elem ) ) {
133133

134134
// Don't re-trigger an onFOO event when we call its FOO() method

‎src/exports/global.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ jQuery.noConflict = function( deep ) {
2525
};
2626

2727
// Expose jQuery and $ identifiers, even in AMD
28-
// (#7102#comment:10, https://github.com/jquery/jquery/pull/557)
29-
// and CommonJS for browser emulators (#13566)
28+
// (trac-7102#comment:10, https://github.com/jquery/jquery/pull/557)
29+
// and CommonJS for browser emulators (trac-13566)
3030
if ( typeof noGlobal === "undefined" ) {
3131
window.jQuery = window.$ = jQuery;
3232
}

‎src/manipulation.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ function domManip( collection, args, callback, ignored ) {
155155

156156
// Use the original fragment for the last item
157157
// instead of the first because it can end up
158-
// being emptied incorrectly in certain situations (#8070).
158+
// being emptied incorrectly in certain situations (trac-8070).
159159
for ( ; i < l; i++ ) {
160160
node = fragment;
161161

‎src/manipulation/_evalUrl.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jQuery._evalUrl = function( url, options, doc ) {
88
return jQuery.ajax( {
99
url: url,
1010

11-
// Make this explicit, since user can override this through ajaxSetup (#11264)
11+
// Make this explicit, since user can override this through ajaxSetup (trac-11264)
1212
type: "GET",
1313
dataType: "script",
1414
cache: true,

‎src/manipulation/buildFragment.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ function buildFragment( elems, context, scripts, selection, ignored ) {
5858
// Remember the top-level container
5959
tmp = fragment.firstChild;
6060

61-
// Ensure the created nodes are orphaned (#12392)
61+
// Ensure the created nodes are orphaned (trac-12392)
6262
tmp.textContent = "";
6363
}
6464
}

‎src/manipulation/getAll.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ define( [
88
function getAll( context, tag ) {
99

1010
// Support: IE <=9 - 11 only
11-
// Use typeof to avoid zero-argument method invocation on host objects (#15151)
11+
// Use typeof to avoid zero-argument method invocation on host objects (trac-15151)
1212
var ret;
1313

1414
if ( typeof context.getElementsByTagName !== "undefined" ) {

‎src/manipulation/support.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ define( [
1111
input = document.createElement( "input" );
1212

1313
// Support: Android 4.0 - 4.3 only
14-
// Check state lost if the name is set (#11217)
14+
// Check state lost if the name is set (trac-11217)
1515
// Support: Windows Web Apps (WWA)
16-
// `name` and `type` must use .setAttribute for WWA (#14901)
16+
// `name` and `type` must use .setAttribute for WWA (trac-14901)
1717
input.setAttribute( "type", "radio" );
1818
input.setAttribute( "checked", "checked" );
1919
input.setAttribute( "name", "t" );

‎src/manipulation/wrapMap.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ define( [
44

55
"use strict";
66

7-
// We have to close these tags to support XHTML (#13200)
7+
// We have to close these tags to support XHTML (trac-13200)
88
var wrapMap = {
99

1010
// XHTML parsers do not magically insert elements in the

‎src/selector-native.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ jQuery.extend( jQuery.find, {
230230
attr: function( elem, name ) {
231231
var fn = jQuery.expr.attrHandle[ name.toLowerCase() ],
232232

233-
// Don't get fooled by Object.prototype properties (jQuery #13807)
233+
// Don't get fooled by Object.prototype properties (jQuery trac-13807)
234234
value = fn && hasOwn.call( jQuery.expr.attrHandle, name.toLowerCase() ) ?
235235
fn( elem, name, jQuery.isXMLDoc( elem ) ) :
236236
undefined;

‎src/wrapper.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
// (such as Node.js), expose a factory as module.exports.
2424
// This accentuates the need for the creation of a real `window`.
2525
// e.g. var jQuery = require("jquery")(window);
26-
// See ticket #14549 for more info.
26+
// See ticket trac-14549 for more info.
2727
module.exports = global.document ?
2828
factory( global, true ) :
2929
function( w ) {

‎test/data/ajax/onunload.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
5-
<title>onunload ajax requests (#14379)</title>
5+
<title>onunload ajax requests (trac-14379)</title>
66
<script src="../../jquery.js"></script>
77
<script src="../iframeTest.js"></script>
88
</head>

‎test/data/core/aliased.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
5-
<title>alias-masked DOM properties (#14074)</title>
5+
<title>alias-masked DOM properties (trac-14074)</title>
66
<script>
77
var errors = [];
88
window.onerror = function( errorMessage, filePath, lineNumber ) {

0 commit comments

Comments
 (0)