Skip to content

Commit 5d5ea01

Browse files
mgolmgol
authored
Docs: Replace #NUMBER Trac issue references with trac-NUMBER
The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing when in jQuery source it's usually referring to the old deprecated Trac instance at https://bugs.jquery.com. This change replaces all such Trac references with `trac-NUMBER`. A few of the references came with the Sizzle integration and referred to the Sizzle GitHub bug tracker. Those have been replaced with full links instead. A new entry describing issue reference conventions has been added to README. Closes gh-4993
1 parent 655c0ed commit 5d5ea01

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+400
-390
lines changed

‎README.md

+6
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ In the spirit of open source software development, jQuery always encourages comm
1414
2. [Core Style Guide](https://contribute.jquery.org/style-guide/js/)
1515
3. [Writing Code for jQuery Foundation Projects](https://contribute.jquery.org/code/)
1616

17+
### References to issues/PRs
18+
19+
GitHub issues/PRs are usually referenced via `gh-NUMBER`, where `NUMBER` is the numerical ID of the issue/PR. You can find such an issue/PR under `https://github.com/jquery/jquery/issues/NUMBER`.
20+
21+
jQuery has used a different bug tracker - based on Trac - in the past, available under [bugs.jquery.com](https://bugs.jquery.com/). It is being kept in read only mode so that referring to past discussions is possible. When jQuery source references one of those issues, it uses the pattern `trac-NUMBER`, where `NUMBER` is the numerical ID of the issue. You can find such an issue under `https://bugs.jquery.com/ticket/NUMBER`.
22+
1723

1824
Environments in which to use jQuery
1925
--------------------------------------

‎src/ajax.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ var
1717
rantiCache = /([?&])_=[^&]*/,
1818
rheaders = /^(.*?):[ \t]*([^\r\n]*)$/mg,
1919

20-
// #7653, #8125, #8152: local protocol detection
20+
// trac-7653, trac-8125, trac-8152: local protocol detection
2121
rlocalProtocol = /^(?:about|app|app-storage|.+-extension|file|res|widget):$/,
2222
rnoContent = /^(?:GET|HEAD)$/,
2323
rprotocol = /^\/\//,
@@ -40,7 +40,7 @@ var
4040
*/
4141
transports = {},
4242

43-
// Avoid comment-prolog char sequence (#10098); must appease lint and evade compression
43+
// Avoid comment-prolog char sequence (trac-10098); must appease lint and evade compression
4444
allTypes = "*/".concat( "*" ),
4545

4646
// Anchor tag for parsing the document origin
@@ -111,7 +111,7 @@ function inspectPrefiltersOrTransports( structure, options, originalOptions, jqX
111111

112112
// A special extend for ajax options
113113
// that takes "flat" options (not to be deep extended)
114-
// Fixes #9887
114+
// Fixes trac-9887
115115
function ajaxExtend( target, src ) {
116116
var key, deep,
117117
flatOptions = jQuery.ajaxSettings.flatOptions || {};
@@ -528,12 +528,12 @@ jQuery.extend( {
528528
deferred.promise( jqXHR );
529529

530530
// Add protocol if not provided (prefilters might expect it)
531-
// Handle falsy url in the settings object (#10093: consistency with old signature)
531+
// Handle falsy url in the settings object (trac-10093: consistency with old signature)
532532
// We also use the url parameter if available
533533
s.url = ( ( url || s.url || location.href ) + "" )
534534
.replace( rprotocol, location.protocol + "//" );
535535

536-
// Alias method option to type as per ticket #12004
536+
// Alias method option to type as per ticket trac-12004
537537
s.type = options.method || options.type || s.method || s.type;
538538

539539
// Extract dataTypes list
@@ -605,7 +605,7 @@ jQuery.extend( {
605605
if ( s.data && ( s.processData || typeof s.data === "string" ) ) {
606606
cacheURL += ( rquery.test( cacheURL ) ? "&" : "?" ) + s.data;
607607

608-
// #9682: remove data so that it's not used in an eventual retry
608+
// trac-9682: remove data so that it's not used in an eventual retry
609609
delete s.data;
610610
}
611611

‎src/ajax/xhr.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jQuery.ajaxTransport( function( options ) {
6666
} else if ( type === "error" ) {
6767
complete(
6868

69-
// File: protocol always yields status 0; see #8605, #14207
69+
// File: protocol always yields status 0; see trac-8605, trac-14207
7070
xhr.status,
7171
xhr.statusText
7272
);
@@ -99,7 +99,7 @@ jQuery.ajaxTransport( function( options ) {
9999
xhr.send( options.hasContent && options.data || null );
100100
} catch ( e ) {
101101

102-
// #14683: Only rethrow if this hasn't been notified as an error yet
102+
// trac-14683: Only rethrow if this hasn't been notified as an error yet
103103
if ( callback ) {
104104
throw e;
105105
}

‎src/attributes/prop.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jQuery.extend( {
6060
// elem.tabIndex doesn't always return the
6161
// correct value when it hasn't been explicitly set
6262
// https://web.archive.org/web/20141116233347/http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
63-
// Use proper attribute retrieval(#12072)
63+
// Use proper attribute retrieval (trac-12072)
6464
var tabindex = elem.getAttribute( "tabindex" );
6565

6666
if ( tabindex ) {

‎src/attributes/val.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ if ( isIE ) {
149149
val :
150150

151151
// Support: IE <=10 - 11+
152-
// option.text throws exceptions (#14686, #14858)
152+
// option.text throws exceptions (trac-14686, trac-14858)
153153
// Strip and collapse whitespace
154154
// https://html.spec.whatwg.org/#strip-and-collapse-whitespace
155155
stripAndCollapse( jQuery.text( elem ) );

‎src/core/init.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import "../traversing/findFilter.js";
1010
var rootjQuery,
1111

1212
// A simple way to check for HTML strings
13-
// Prioritize #id over <tag> to avoid XSS via location.hash (#9521)
14-
// Strict HTML recognition (#11290: must start with <)
13+
// Prioritize #id over <tag> to avoid XSS via location.hash (trac-9521)
14+
// Strict HTML recognition (trac-11290: must start with <)
1515
// Shortcut simple #id case for speed
1616
rquickExpr = /^(?:\s*(<[\w\W]+>)[^>]*|#([\w-]+))$/,
1717

‎src/core/ready-no-deferred.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jQuery.extend( {
2525
isReady: false,
2626

2727
// A counter to track how many items to wait for before
28-
// the ready event fires. See #6781
28+
// the ready event fires. See trac-6781
2929
readyWait: 1,
3030

3131
ready: function( wait ) {

‎src/core/ready.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jQuery.extend( {
2828
isReady: false,
2929

3030
// A counter to track how many items to wait for before
31-
// the ready event fires. See #6781
31+
// the ready event fires. See trac-6781
3232
readyWait: 1,
3333

3434
// Handle when the DOM is ready

‎src/css.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -220,15 +220,15 @@ jQuery.extend( {
220220
if ( value !== undefined ) {
221221
type = typeof value;
222222

223-
// Convert "+=" or "-=" to relative numbers (#7345)
223+
// Convert "+=" or "-=" to relative numbers (trac-7345)
224224
if ( type === "string" && ( ret = rcssNum.exec( value ) ) && ret[ 1 ] ) {
225225
value = adjustCSS( elem, name, ret );
226226

227-
// Fixes bug #9237
227+
// Fixes bug trac-9237
228228
type = "number";
229229
}
230230

231-
// Make sure that null and NaN values aren't set (#7116)
231+
// Make sure that null and NaN values aren't set (trac-7116)
232232
if ( value == null || value !== value ) {
233233
return;
234234
}
@@ -239,7 +239,7 @@ jQuery.extend( {
239239
}
240240

241241
// Support: IE <=9 - 11+
242-
// background-* props of a cloned element affect the source element (#8908)
242+
// background-* props of a cloned element affect the source element (trac-8908)
243243
if ( isIE && value === "" && name.indexOf( "background" ) === 0 ) {
244244
style[ name ] = "inherit";
245245
}

‎src/css/cssCamelCase.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ var rmsPrefix = /^-ms-/;
66
// Convert dashed to camelCase, handle vendor prefixes.
77
// Used by the css & effects modules.
88
// Support: IE <=9 - 11+
9-
// Microsoft forgot to hump their vendor prefix (#9572)
9+
// Microsoft forgot to hump their vendor prefix (trac-9572)
1010
function cssCamelCase( string ) {
1111
return camelCase( string.replace( rmsPrefix, "ms-" ) );
1212
}

‎src/data.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ jQuery.fn.extend( {
105105
while ( i-- ) {
106106

107107
// Support: IE 11+
108-
// The attrs elements can be null (#14894)
108+
// The attrs elements can be null (trac-14894)
109109
if ( attrs[ i ] ) {
110110
name = attrs[ i ].name;
111111
if ( name.indexOf( "data-" ) === 0 ) {

‎src/data/Data.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Data.prototype = {
2121
value = Object.create( null );
2222

2323
// We can accept data for non-element nodes in modern browsers,
24-
// but we should not, see #8335.
24+
// but we should not, see trac-8335.
2525
// Always return an empty object.
2626
if ( acceptData( owner ) ) {
2727

‎src/event.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -369,15 +369,15 @@ jQuery.event = {
369369

370370
for ( ; cur !== this; cur = cur.parentNode || this ) {
371371

372-
// Don't check non-elements (#13208)
373-
// Don't process clicks on disabled elements (#6911, #8165, #11382, #11764)
372+
// Don't check non-elements (trac-13208)
373+
// Don't process clicks on disabled elements (trac-6911, trac-8165, trac-11382, trac-11764)
374374
if ( cur.nodeType === 1 && !( event.type === "click" && cur.disabled === true ) ) {
375375
matchedHandlers = [];
376376
matchedSelectors = {};
377377
for ( i = 0; i < delegateCount; i++ ) {
378378
handleObj = handlers[ i ];
379379

380-
// Don't conflict with Object.prototype properties (#13203)
380+
// Don't conflict with Object.prototype properties (trac-13203)
381381
sel = handleObj.selector + " ";
382382

383383
if ( matchedSelectors[ sel ] === undefined ) {

‎src/event/trigger.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ jQuery.extend( jQuery.event, {
7171
return;
7272
}
7373

74-
// Determine event propagation path in advance, per W3C events spec (#9951)
75-
// Bubble up to document, then to window; watch for a global ownerDocument var (#9724)
74+
// Determine event propagation path in advance, per W3C events spec (trac-9951)
75+
// Bubble up to document, then to window; watch for a global ownerDocument var (trac-9724)
7676
if ( !onlyHandlers && !special.noBubble && !isWindow( elem ) ) {
7777

7878
bubbleType = special.delegateType || type;
@@ -124,7 +124,7 @@ jQuery.extend( jQuery.event, {
124124
acceptData( elem ) ) {
125125

126126
// Call a native DOM method on the target with the same name as the event.
127-
// Don't do default actions on window, that's where global variables be (#6170)
127+
// Don't do default actions on window, that's where global variables be (trac-6170)
128128
if ( ontype && typeof elem[ type ] === "function" && !isWindow( elem ) ) {
129129

130130
// Don't re-trigger an onFOO event when we call its FOO() method

‎src/exports/global.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ jQuery.noConflict = function( deep ) {
2121
};
2222

2323
// Expose jQuery and $ identifiers, even in AMD
24-
// (#7102#comment:10, https://github.com/jquery/jquery/pull/557)
25-
// and CommonJS for browser emulators (#13566)
24+
// (trac-7102#comment:10, gh-557)
25+
// and CommonJS for browser emulators (trac-13566)
2626
if ( typeof noGlobal === "undefined" ) {
2727
window.jQuery = window.$ = jQuery;
2828
}

‎src/manipulation.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ function domManip( collection, args, callback, ignored ) {
120120

121121
// Use the original fragment for the last item
122122
// instead of the first because it can end up
123-
// being emptied incorrectly in certain situations (#8070).
123+
// being emptied incorrectly in certain situations (trac-8070).
124124
for ( ; i < l; i++ ) {
125125
node = fragment;
126126

‎src/manipulation/_evalUrl.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ jQuery._evalUrl = function( url, options, doc ) {
44
return jQuery.ajax( {
55
url: url,
66

7-
// Make this explicit, since user can override this through ajaxSetup (#11264)
7+
// Make this explicit, since user can override this through ajaxSetup (trac-11264)
88
type: "GET",
99
dataType: "script",
1010
cache: true,

‎src/manipulation/buildFragment.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function buildFragment( elems, context, scripts, selection, ignored ) {
5252
// Remember the top-level container
5353
tmp = fragment.firstChild;
5454

55-
// Ensure the created nodes are orphaned (#12392)
55+
// Ensure the created nodes are orphaned (trac-12392)
5656
tmp.textContent = "";
5757
}
5858
}

‎src/manipulation/getAll.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import nodeName from "../core/nodeName.js";
44
function getAll( context, tag ) {
55

66
// Support: IE <=9 - 11+
7-
// Use typeof to avoid zero-argument method invocation on host objects (#15151)
7+
// Use typeof to avoid zero-argument method invocation on host objects (trac-15151)
88
var ret;
99

1010
if ( typeof context.getElementsByTagName !== "undefined" ) {

‎src/selector.js

+7-4
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,8 @@ function createCache() {
282282

283283
function cache( key, value ) {
284284

285-
// Use (key + " ") to avoid collision with native prototype properties (see Issue #157)
285+
// Use (key + " ") to avoid collision with native prototype properties
286+
// (see https://github.com/jquery/sizzle/issues/157)
286287
if ( keys.push( key + " " ) > Expr.cacheLength ) {
287288

288289
// Only keep the most recent entries
@@ -432,7 +433,7 @@ function setDocument( node ) {
432433
documentIsHTML = !jQuery.isXMLDoc( document );
433434

434435
// Support: IE 9 - 11+
435-
// Accessing iframe documents after unload throws "permission denied" errors (jQuery #13936)
436+
// Accessing iframe documents after unload throws "permission denied" errors (see trac-13936)
436437
// Support: IE 11+
437438
// IE sometimes throws a "Permission denied" error when strict-comparing
438439
// two documents; shallow comparisons work.
@@ -843,7 +844,8 @@ Expr = jQuery.expr = {
843844
input[ 0 ] = elem;
844845
matcher( input, null, xml, results );
845846

846-
// Don't keep the element (issue #299)
847+
// Don't keep the element
848+
// (see https://github.com/jquery/sizzle/issues/299)
847849
input[ 0 ] = null;
848850
return !results.pop();
849851
};
@@ -1348,7 +1350,8 @@ function matcherFromTokens( tokens ) {
13481350
matchContext( elem, context, xml ) :
13491351
matchAnyContext( elem, context, xml ) );
13501352

1351-
// Avoid hanging onto element (issue #299)
1353+
// Avoid hanging onto element
1354+
// (see https://github.com/jquery/sizzle/issues/299)
13521355
checkContext = null;
13531356
return ret;
13541357
} ];

‎src/wrapper.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// (such as Node.js), expose a factory as module.exports.
2121
// This accentuates the need for the creation of a real `window`.
2222
// e.g. var jQuery = require("jquery")(window);
23-
// See ticket #14549 for more info.
23+
// See ticket trac-14549 for more info.
2424
module.exports = global.document ?
2525
factory( global, true ) :
2626
function( w ) {

‎test/data/ajax/onunload.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
5-
<title>onunload ajax requests (#14379)</title>
5+
<title>onunload ajax requests (trac-14379)</title>
66
<script src="../../jquery.js"></script>
77
<script src="../iframeTest.js"></script>
88
</head>

‎test/data/core/aliased.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
5-
<title>alias-masked DOM properties (#14074)</title>
5+
<title>alias-masked DOM properties (trac-14074)</title>
66
<script>
77
var errors = [];
88
window.onerror = function( errorMessage, filePath, lineNumber ) {

‎test/data/core/onready.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
5-
<title>alias-masked DOM properties (#14074)</title>
5+
<title>alias-masked DOM properties (trac-14074)</title>
66
<script>
77
var error = false;
88
window.onready = function() { error = "Called window.onready"; };
@@ -22,4 +22,4 @@
2222
});
2323
</script>
2424
</body>
25-
</html>
25+
</html>

‎test/data/data/dataAttrs.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
5-
<title>IE11 onpageshow strangeness (#14894)</title>
5+
<title>IE11 onpageshow strangeness (trac-14894)</title>
66
<script src="../../jquery.js"></script>
77
<script src="../iframeTest.js"></script>
88
<script>
@@ -12,6 +12,6 @@
1212
</script>
1313
</head>
1414
<body x-what="test" data-result="ok" onload="x=1" onpageshow="x=1">
15-
Test for #14894
15+
Test for trac-14894
1616
</body>
1717
</html>

‎test/data/event/focusElem.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta http-equiv="Content-type" content="text/html; charset=utf-8">
5-
<title>.focus() (activeElement access #13393)</title>
5+
<title>.focus() (activeElement access trac-13393)</title>
66

77
<script src="../../jquery.js"></script>
88
<script src="../iframeTest.js"></script>

‎test/data/event/focusinCrossFrame.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta http-equiv="Content-type" content="text/html; charset=utf-8">
5-
<title>focusin event cross-frame (#14180)</title>
5+
<title>focusin event cross-frame (trac-14180)</title>
66

77
<script src="../../jquery.js"></script>
88
<script src="../iframeTest.js"></script>

‎test/data/event/promiseReady.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33
<head>
44
<meta http-equiv="content-type" content="text/html; charset=utf-8">
5-
<title>Test case for jQuery ticket #11470</title>
5+
<title>Test case for jQuery ticket trac-11470</title>
66
<script src="../../jquery.js"></script>
77
<script src="../iframeTest.js"></script>
88
<script type="text/javascript">

0 commit comments

Comments
 (0)