Ajax: execute jQuery#load callback with correct context

markelog · timmywil · commit 5d20a3c3f10b · 2016-04-04T16:22:35.000-04:00
Thanks @blq (Fredrik Blomqvist) Fixes gh-3035 Close gh-3039
diff --git a/src/ajax/load.js b/src/ajax/load.js
@@ -62,7 +62,7 @@ jQuery.fn.load = function( url, params, callback ) {
 		// If it fails, this function gets "jqXHR", "status", "error"
 		} ).always( callback && function( jqXHR, status ) {
 			self.each( function() {
-				callback.apply( self, response || [ jqXHR.responseText, status, jqXHR ] );
+				callback.apply( this, response || [ jqXHR.responseText, status, jqXHR ] );
 			} );
 		} );
 	}
diff --git a/test/unit/ajax.js b/test/unit/ajax.js
@@ -2084,6 +2084,25 @@ if ( typeof window.ArrayBuffer === "undefined" || typeof new XMLHttpRequest().re
 		}
 	);
 
+	QUnit.test(
+		"jQuery#load() - should resolve with correct context", 2,
+		function( assert ) {
+			var done = assert.async();
+			var ps = jQuery( "<p></p><p></p>" );
+			var i = 0;
+
+			ps.appendTo( "#qunit-fixture" );
+
+			ps.load( "data/ajax/method.php", function() {
+				assert.strictEqual( this, ps[ i++ ] );
+
+				if ( i === 2 ) {
+					done();
+				}
+			} );
+		}
+	);
+
 	QUnit.test(
 		"#11402 - jQuery.domManip() - script in comments are properly evaluated", 2,
 		function( assert ) {

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ jQuery.fn.load = function( url, params, callback ) {`
`62`	`62`	`// If it fails, this function gets "jqXHR", "status", "error"`
`63`	`63`	`} ).always( callback && function( jqXHR, status ) {`
`64`	`64`	`self.each( function() {`
`65`		`- callback.apply( self, response \|\| [ jqXHR.responseText, status, jqXHR ] );`
	`65`	`+ callback.apply( this, response \|\| [ jqXHR.responseText, status, jqXHR ] );`
`66`	`66`	`} );`
`67`	`67`	`} );`
`68`	`68`	`}`