Skip to content

Commit 50e8e84

Browse files
mgolmgol
authored
Tests: Make more tests run natively in Chrome & Firefox
Chrome & Firefox now support complex `:not()` selectors so those test can run in them even without custom jQuery selector code. In the past, it was only possible in Safari, now we only need to exclude IE. Closes gh-4864
1 parent 345cd22 commit 50e8e84

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

‎test/unit/selector.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -1137,14 +1137,14 @@ QUnit.test( "pseudo - :not", function( assert ) {
11371137
assert.t( ":not() failing interior", "#qunit-fixture p:not(.foo)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
11381138
assert.t( ":not() failing interior", "#qunit-fixture p:not(#blargh)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
11391139

1140-
if ( QUnit.jQuerySelectors || this.safari ) {
1140+
if ( QUnit.jQuerySelectors || !QUnit.isIE ) {
11411141
assert.t( ":not() failing interior", "#qunit-fixture p:not(div.foo)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
11421142
assert.t( ":not() failing interior", "#qunit-fixture p:not(p.foo)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
11431143
assert.t( ":not() failing interior", "#qunit-fixture p:not(div#blargh)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
11441144
assert.t( ":not() failing interior", "#qunit-fixture p:not(p#blargh)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
11451145
} else {
1146-
// Support: Chrome 75+, Firefox 67+
1147-
// Chrome/Firefox don't support `:not(complex selector)`.
1146+
// Support: IE 11+
1147+
// IE doesn't support `:not(complex selector)`.
11481148
assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
11491149
assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
11501150
assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
@@ -1156,15 +1156,15 @@ QUnit.test( "pseudo - :not", function( assert ) {
11561156
assert.t( ":not Multiple", "#qunit-fixture p:not( p )", [] );
11571157
assert.t( ":not Multiple", "p:not(p)", [] );
11581158

1159-
if ( QUnit.jQuerySelectors || this.safari ) {
1159+
if ( QUnit.jQuerySelectors || !QUnit.isIE ) {
11601160
assert.t( ":not Multiple", "#qunit-fixture p:not(a, b)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
11611161
assert.t( ":not Multiple", "#qunit-fixture p:not(a, b, div)", [ "firstp", "ap", "sndp", "en", "sap", "first" ] );
11621162
assert.t( ":not Multiple", "p:not(a,p)", [] );
11631163
assert.t( ":not Multiple", "p:not(p,a)", [] );
11641164
assert.t( ":not Multiple", "p:not(a,p,b)", [] );
11651165
} else {
1166-
// Support: Chrome 75+, Firefox 67+
1167-
// Chrome/Firefox don't support `:not(complex selector)`.
1166+
// Support: IE 11+
1167+
// IE doesn't support `:not(complex selector)`.
11681168
assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
11691169
assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
11701170
assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
@@ -1189,11 +1189,11 @@ QUnit.test( "pseudo - :not", function( assert ) {
11891189
assert.t( ":not() Multiple Class", "#foo a:not(.blog)", [ "yahoo", "anchor2" ] );
11901190
assert.t( ":not() Multiple Class", "#foo a:not(.link)", [ "yahoo", "anchor2" ] );
11911191

1192-
if ( QUnit.jQuerySelectors || this.safari ) {
1192+
if ( QUnit.jQuerySelectors || !QUnit.isIE ) {
11931193
assert.t( ":not() Multiple Class", "#foo a:not(.blog.link)", [ "yahoo", "anchor2" ] );
11941194
} else {
1195-
// Support: Chrome 75+, Firefox 67+
1196-
// Chrome/Firefox don't support `:not(complex selector)`.
1195+
// Support: IE 11+
1196+
// IE doesn't support `:not(complex selector)`.
11971197
assert.ok( "skip", ":not(complex selector) not supported in selector-native" );
11981198
}
11991199

0 commit comments

Comments
 (0)