Made .clone(true) also copy over element data. Fixes #4191.

jeresig · jeresig · commit 4b70f006f579 · 2009-12-09T13:28:58.000-08:00
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -277,13 +277,7 @@ function cloneCopyEvent(orig, ret) {
 			return;
 		}
 
-		var events = jQuery.data( orig[i], "events" );
-
-		for ( var type in events ) {
-			for ( var handler in events[ type ] ) {
-				jQuery.event.add( this, type, events[ type ][ handler ], events[ type ][ handler ].data );
-			}
-		}
+		jQuery.data( this, jQuery.data( orig[i++] ) );
 	});
 }
 
diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
@@ -549,7 +549,7 @@ test("replaceAll(String|Element|Array&lt;Element&gt;|jQuery)", function() {
 });
 
 test("clone()", function() {
-	expect(28);
+	expect(30);
 	equals( 'This is a normal link: Yahoo', jQuery('#en').text(), 'Assert text for #en' );
 	var clone = jQuery('#yahoo').clone();
 	equals( 'Try them out:Yahoo', jQuery('#first').append(clone).text(), 'Check for clone' );
@@ -594,6 +594,11 @@ test("clone()", function() {
 	div = div.clone(true);
 	equals( div.length, 1, "One element cloned" );
 	equals( div[0].nodeName.toUpperCase(), "DIV", "DIV element cloned" );
+
+	div = jQuery("<div/>").data({ a: true, b: true });
+	div = div.clone(true);
+	equals( div.data("a"), true, "Data cloned." );
+	equals( div.data("b"), true, "Data cloned." );
 });
 
 if (!isLocal) {

Original file line number	Diff line number	Diff line change
`@@ -277,13 +277,7 @@ function cloneCopyEvent(orig, ret) {`
`277`	`277`	`return;`
`278`	`278`	`}`
`279`	`279`
`280`		`- var events = jQuery.data( orig[i], "events" );`
`281`		`-`
`282`		`- for ( var type in events ) {`
`283`		`- for ( var handler in events[ type ] ) {`
`284`		`- jQuery.event.add( this, type, events[ type ][ handler ], events[ type ][ handler ].data );`
`285`		`- }`
`286`		`- }`
	`280`	`+ jQuery.data( this, jQuery.data( orig[i++] ) );`
`287`	`281`	`});`
`288`	`282`	`}`
`289`	`283`