Skip to content

Commit 438b1a3

Browse files
mgolmgol
authored
Build: ESLint: forbid unused function parameters
This commit requires all function parameters to be used, not just the last one. In cases where that's not possible as we need to match an external API, there's an escape hatch of prefixing an unused argument with `_`. This change makes it easier to catch unused AMD dependencies and unused parameters in internal functions the API of which we may change at will, among other things. Unused AMD dependencies have been removed as part of this commit. Closes gh-4381
1 parent 9ec09c3 commit 438b1a3

19 files changed

+27
-37
lines changed

‎build/tasks/build.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ module.exports = function( grunt ) {
372372

373373
// Ask for permission the first time
374374
if ( insight.optOut === undefined ) {
375-
insight.askPermission( null, function( error, result ) {
375+
insight.askPermission( null, function( _error, result ) {
376376
exec( result );
377377
} );
378378
} else {

‎dist/.eslintrc.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@
77
// That is okay for the built version
88
"no-multiple-empty-lines": "off",
99

10-
// Because sizzle is not compatible to jquery code style
10+
// Sizzle is not compatible with jQuery code style
1111
"no-nested-ternary": "off",
1212
"no-unused-expressions": "off",
13+
"no-unused-vars": "off",
1314
"lines-around-comment": "off",
1415
"space-in-parens": "off",
1516
"camelcase": "off",

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"@babel/plugin-transform-for-of": "7.4.3",
3030
"commitplease": "3.2.0",
3131
"core-js-bundle": "3.0.0",
32-
"eslint-config-jquery": "1.0.1",
32+
"eslint-config-jquery": "2.0.0",
3333
"grunt": "1.0.4",
3434
"grunt-babel": "8.0.0",
3535
"grunt-cli": "1.3.2",

‎src/ajax.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -838,7 +838,7 @@ jQuery.extend( {
838838
}
839839
} );
840840

841-
jQuery.each( [ "get", "post" ], function( i, method ) {
841+
jQuery.each( [ "get", "post" ], function( _i, method ) {
842842
jQuery[ method ] = function( url, data, callback, type ) {
843843

844844
// Shift arguments if data argument was omitted

‎src/attributes/attr.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ boolHook = {
119119
}
120120
};
121121

122-
jQuery.each( jQuery.expr.match.bool.source.match( /\w+/g ), function( i, name ) {
122+
jQuery.each( jQuery.expr.match.bool.source.match( /\w+/g ), function( _i, name ) {
123123
var getter = attrHandle[ name ] || jQuery.find.attr;
124124

125125
attrHandle[ name ] = function( elem, name, isXML ) {

‎src/core.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
define( [
66
"./var/arr",
7-
"./var/document",
87
"./var/getProto",
98
"./var/slice",
109
"./var/concat",
@@ -20,7 +19,7 @@ define( [
2019
"./var/isWindow",
2120
"./core/DOMEval",
2221
"./core/toType"
23-
], function( arr, document, getProto, slice, concat, push, indexOf,
22+
], function( arr, getProto, slice, concat, push, indexOf,
2423
class2type, toString, hasOwn, fnToString, ObjectFunctionString,
2524
trim, support, isWindow, DOMEval, toType ) {
2625

@@ -365,7 +364,7 @@ if ( typeof Symbol === "function" ) {
365364

366365
// Populate the class2type map
367366
jQuery.each( "Boolean Number String Function Array Date RegExp Object Error Symbol".split( " " ),
368-
function( i, name ) {
367+
function( _i, name ) {
369368
class2type[ "[object " + name + "]" ] = name.toLowerCase();
370369
} );
371370

‎src/core/access.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ var access = function( elems, fn, key, value, chainable, emptyGet, raw ) {
3737
// ...except when executing function values
3838
} else {
3939
bulk = fn;
40-
fn = function( elem, key, value ) {
40+
fn = function( elem, _key, value ) {
4141
return bulk.call( jQuery( elem ), value );
4242
};
4343
}

‎src/core/camelCase.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ define( [], function() {
66
var rdashAlpha = /-([a-z])/g;
77

88
// Used by camelCase as callback to replace()
9-
function fcamelCase( all, letter ) {
9+
function fcamelCase( _all, letter ) {
1010
return letter.toUpperCase();
1111
}
1212

‎src/css.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ var
3434
fontWeight: "400"
3535
};
3636

37-
function setPositiveNumber( elem, value, subtract ) {
37+
function setPositiveNumber( _elem, value, subtract ) {
3838

3939
// Any relative (+/-) values have already been
4040
// normalized at this point
@@ -311,7 +311,7 @@ jQuery.extend( {
311311
}
312312
} );
313313

314-
jQuery.each( [ "height", "width" ], function( i, dimension ) {
314+
jQuery.each( [ "height", "width" ], function( _i, dimension ) {
315315
jQuery.cssHooks[ dimension ] = {
316316
get: function( elem, computed, extra ) {
317317
if ( computed ) {

‎src/css/var/swap.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ define( function() {
33
"use strict";
44

55
// A method for quickly swapping in/out CSS properties to get correct calculations.
6-
return function( elem, options, callback, args ) {
6+
return function( elem, options, callback ) {
77
var ret, name,
88
old = {};
99

@@ -13,7 +13,7 @@ return function( elem, options, callback, args ) {
1313
elem.style[ name ] = options[ name ];
1414
}
1515

16-
ret = callback.apply( elem, args || [] );
16+
ret = callback.call( elem );
1717

1818
// Revert the old values
1919
for ( name in options ) {

‎src/deferred.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ jQuery.extend( {
7575
var fns = arguments;
7676

7777
return jQuery.Deferred( function( newDefer ) {
78-
jQuery.each( tuples, function( i, tuple ) {
78+
jQuery.each( tuples, function( _i, tuple ) {
7979

8080
// Map tuples (progress, done, fail) to arguments (done, fail, progress)
8181
var fn = typeof fns[ tuple[ 4 ] ] === "function" &&

‎src/deprecated.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
define( [
22
"./core",
3-
"./core/nodeName",
4-
"./core/toType",
5-
"./css/cssCamelCase",
6-
"./var/isWindow",
73
"./var/slice",
84

95
"./event/alias"
10-
], function( jQuery, nodeName, toType, cssCamelCase, isWindow, slice ) {
6+
], function( jQuery, slice ) {
117

128
"use strict";
139

‎src/effects.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ define( [
55
"./var/rnothtmlwhite",
66
"./css/var/cssExpand",
77
"./css/var/isHiddenWithinTree",
8-
"./css/var/swap",
98
"./css/adjustCSS",
109
"./css/cssCamelCase",
1110
"./data/var/dataPriv",
@@ -19,7 +18,7 @@ define( [
1918
"./css",
2019
"./effects/Tween"
2120
], function( jQuery, document, rcssNum, rnothtmlwhite, cssExpand,
22-
isHiddenWithinTree, swap, adjustCSS, cssCamelCase, dataPriv, showHide ) {
21+
isHiddenWithinTree, adjustCSS, cssCamelCase, dataPriv, showHide ) {
2322

2423
"use strict";
2524

@@ -621,7 +620,7 @@ jQuery.fn.extend( {
621620
}
622621
} );
623622

624-
jQuery.each( [ "toggle", "show", "hide" ], function( i, name ) {
623+
jQuery.each( [ "toggle", "show", "hide" ], function( _i, name ) {
625624
var cssFn = jQuery.fn[ name ];
626625
jQuery.fn[ name ] = function( speed, easing, callback ) {
627626
return speed == null || typeof speed === "boolean" ?

‎src/event/ajax.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jQuery.each( [
1313
"ajaxError",
1414
"ajaxSuccess",
1515
"ajaxSend"
16-
], function( i, type ) {
16+
], function( _i, type ) {
1717
jQuery.fn[ type ] = function( fn ) {
1818
return this.on( type, fn );
1919
};

‎src/event/alias.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ define( [
1010
jQuery.each( ( "blur focus focusin focusout resize scroll click dblclick " +
1111
"mousedown mouseup mousemove mouseover mouseout mouseenter mouseleave " +
1212
"change select submit keydown keypress keyup contextmenu" ).split( " " ),
13-
function( i, name ) {
13+
function( _i, name ) {
1414

1515
// Handle event binding
1616
jQuery.fn[ name ] = function( data, fn ) {

‎src/manipulation.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ define( [
44
"./var/concat",
55
"./var/isIE",
66
"./var/push",
7-
"./var/rcheckableType",
87
"./core/access",
98
"./manipulation/var/rtagName",
109
"./manipulation/var/rscriptType",
@@ -23,9 +22,8 @@ define( [
2322
"./traversing",
2423
"./selector",
2524
"./event"
26-
], function( jQuery, isAttached, concat, isIE, push,
27-
rcheckableType, access, rtagName, rscriptType,
28-
wrapMap, getAll, setGlobalEval, buildFragment,
25+
], function( jQuery, isAttached, concat, isIE, push, access, rtagName,
26+
rscriptType, wrapMap, getAll, setGlobalEval, buildFragment,
2927
dataPriv, dataUser, acceptData, DOMEval, nodeName ) {
3028

3129
"use strict";

‎src/offset.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
define( [
22
"./core",
33
"./core/access",
4-
"./var/document",
54
"./var/documentElement",
6-
"./css/var/rnumnonpx",
7-
"./css/curCSS",
85
"./var/isWindow",
96
"./core/init",
107
"./css",
118
"./selector" // contains
12-
], function( jQuery, access, document, documentElement, rnumnonpx, curCSS, isWindow ) {
9+
], function( jQuery, access, documentElement, isWindow ) {
1310

1411
"use strict";
1512

‎src/serialize.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ jQuery.fn.extend( {
113113
rsubmittable.test( this.nodeName ) && !rsubmitterTypes.test( type ) &&
114114
( this.checked || !rcheckableType.test( type ) );
115115
} )
116-
.map( function( i, elem ) {
116+
.map( function( _i, elem ) {
117117
var val = jQuery( this ).val();
118118

119119
if ( val == null ) {

‎src/traversing.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ jQuery.each( {
118118
parents: function( elem ) {
119119
return dir( elem, "parentNode" );
120120
},
121-
parentsUntil: function( elem, i, until ) {
121+
parentsUntil: function( elem, _i, until ) {
122122
return dir( elem, "parentNode", until );
123123
},
124124
next: function( elem ) {
@@ -133,10 +133,10 @@ jQuery.each( {
133133
prevAll: function( elem ) {
134134
return dir( elem, "previousSibling" );
135135
},
136-
nextUntil: function( elem, i, until ) {
136+
nextUntil: function( elem, _i, until ) {
137137
return dir( elem, "nextSibling", until );
138138
},
139-
prevUntil: function( elem, i, until ) {
139+
prevUntil: function( elem, _i, until ) {
140140
return dir( elem, "previousSibling", until );
141141
},
142142
siblings: function( elem ) {

0 commit comments

Comments
 (0)