Skip to content

Commit 3fce794

Browse files
committed
Fix #12733. Ignore excess spaciness in event strings.
Thanks @bentruyman!
1 parent 6b00b3c commit 3fce794

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/event.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
var rformElems = /^(?:textarea|input|select)$/i,
22
rtypenamespace = /^([^\.]*|)(?:\.(.+)|)$/,
3+
reventTypes = /\S+/g,
34
rkeyEvent = /^key/,
45
rmouseEvent = /^(?:mouse|contextmenu)|click/,
56
rfocusMorph = /^(?:focusinfocus|focusoutblur)$/;
@@ -52,7 +53,7 @@ jQuery.event = {
5253

5354
// Handle multiple events separated by a space
5455
// jQuery(...).bind("mouseover mouseout", fn);
55-
types = jQuery.trim( types ).split( " " );
56+
types = (types || "").match( reventTypes ) || [""];
5657
for ( t = 0; t < types.length; t++ ) {
5758

5859
tns = rtypenamespace.exec( types[t] ) || [];
@@ -135,7 +136,7 @@ jQuery.event = {
135136
}
136137

137138
// Once for each type.namespace in types; type may be omitted
138-
types = jQuery.trim( types ).split(" ");
139+
types = (types || "").match( reventTypes ) || [""];
139140
for ( t = 0; t < types.length; t++ ) {
140141
tns = rtypenamespace.exec( types[t] ) || [];
141142
type = origType = tns[1];

test/unit/event.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2650,7 +2650,7 @@ test(".on and .off", function() {
26502650
counter += (e.data || 0) + (trig || 1);
26512651
};
26522652
jQuery( "#onandoff" )
2653-
.on( "click clack cluck", "em", 2, mixfn )
2653+
.on( " click clack cluck ", "em", 2, mixfn )
26542654
.on( "cluck", "b", 7, mixfn )
26552655
.on( "cluck", mixfn )
26562656
.trigger( "what!" )

0 commit comments

Comments
 (0)