CSS: Include show, hide & toggle methods in the jQuery slim build

mgol · web-flow · commit 297d18dd13f7 · 2020-05-05T14:16:41.000+02:00
The `show()`, `hide()` & `toggle()` methods were included in the 3.x jQuery slim build. The jQuery master build accidentally started to exclude them as they were only imported in the effects module and the new Rollup-based build system follows the module dependency graph when excluding modules. To resolve the issue, import the `css/showHide.js` file directly in the main `jquery.js` file. Closes gh-4704 Ref jquery/jquery-migrate#346
diff --git a/src/jquery.js b/src/jquery.js
@@ -16,6 +16,7 @@ import "./manipulation/_evalUrl.js";
 import "./wrap.js";
 import "./css.js";
 import "./css/hiddenVisibleSelectors.js";
+import "./css/showHide.js";
 import "./serialize.js";
 import "./ajax.js";
 import "./ajax/xhr.js";
diff --git a/test/unit/css.js b/test/unit/css.js
@@ -487,9 +487,6 @@ QUnit.test( "css(Object) where values are Functions with incoming values", funct
 	jQuery( "#cssFunctionTest" ).remove();
 } );
 
-// .show(), .hide(), can be excluded from the build
-if ( jQuery.fn.show && jQuery.fn.hide ) {
-
 QUnit.test( "show()", function( assert ) {
 
 	assert.expect( 18 );
@@ -968,8 +965,6 @@ QUnit.test( "show/hide 3.0, inline hidden", function( assert ) {
 	} );
 } );
 
-}
-
 QUnit[ QUnit.jQuerySelectors && jQuery.fn.toggle ? "test" : "skip" ]( "toggle()", function( assert ) {
 	assert.expect( 9 );
 	var div, oldHide,
