Traversing: .not/.filter consistency with non-elements

vanderlee · timmywil · commit 0e2f8f9effd2 · 2016-01-13T13:33:01.000-05:00
Fixes gh-2808 Close gh-2809
diff --git a/src/traversing/findFilter.js b/src/traversing/findFilter.js
@@ -33,7 +33,7 @@ function winnow( elements, qualifier, not ) {
 	}
 
 	return jQuery.grep( elements, function( elem ) {
-		return ( indexOf.call( qualifier, elem ) > -1 ) !== not;
+		return ( indexOf.call( qualifier, elem ) > -1 ) !== not && elem.nodeType === 1;
 	} );
 }
 
diff --git a/test/unit/traversing.js b/test/unit/traversing.js
@@ -430,6 +430,17 @@ QUnit.test( "not(jQuery)", function( assert ) {
 	assert.deepEqual( jQuery( "p" ).not( jQuery( "#ap, #sndp, .result" ) ).get(), q( "firstp", "en", "sap", "first" ), "not(jQuery)" );
 } );
 
+QUnit.test( "not(Selector) excludes non-element nodes (gh-2808)", function( assert ) {
+	assert.expect( 3 );
+
+	var mixedContents = jQuery( "#nonnodes" ).contents(),
+		childElements = q( "nonnodesElement" );
+
+	assert.deepEqual( mixedContents.not( "*" ).get(), [], "not *" );
+	assert.deepEqual( mixedContents.not( "[id=a],[id=b]" ).get(), childElements, "not [id=a],[id=b]" );
+	assert.deepEqual( mixedContents.not( "[id=a],*,[id=b]" ).get(), [], "not [id=a],*,[id=b]" );
+} );
+
 QUnit.test( "has(Element)", function( assert ) {
 	assert.expect( 3 );
 	var obj, detached, multipleParent;

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ function winnow( elements, qualifier, not ) {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`return jQuery.grep( elements, function( elem ) {`
`36`		`- return ( indexOf.call( qualifier, elem ) > -1 ) !== not;`
	`36`	`+ return ( indexOf.call( qualifier, elem ) > -1 ) !== not && elem.nodeType === 1;`
`37`	`37`	`} );`
`38`	`38`	`}`
`39`	`39`