Build: Switch from UglifyJS to SWC minify, make the minified file ES5 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More recent UglifyJS versions have started converting regular functions to arrow ones, making ES5 source file migrated to a ES2015+ minified one. We want to avoid that even in 1.14.x as long as we keep the source file in ES5. But the bigger problem is that we generate ES2015+ minified code even for 1.13.3 releases which support IE. Closes jquerygh-629 Ref mishoo/UglifyJS#5967 Ref jquery#629
timmywil
approved these changes
Mar 3, 2025
The previous versions no longer work.
mgol
force-pushed
the
swc-minify
branch
2 times, most recently
from
bbc7b6f to
0df48a9
Compare
|
@timmywil I had to update GitHub Actions as the older ones didn't work anymore; I copied automatic Dependabot updates setup from Core as well. I reverted the minifier change to make sure new tests fail and they do, with expected messages complaining about parsing errors: I reverted the reverts and the PR is green now. |
timmywil
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More recent UglifyJS versions have started converting regular functions to arrow ones, making ES5 source file migrated to a ES2015+ minified one. We want to avoid that even in 1.14.x as long as we keep the source file in ES5. But the bigger problem is that we generate ES2015+ minified code even for 1.13.3 releases which support IE.
Fixes gh-629
Ref mishoo/UglifyJS#5967
Ref #629