Skip to content

All: Fix button selectors #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
May 3, 2023
Merged

All: Fix button selectors #1227

mgol merged 1 commit into from
May 3, 2023

Conversation

@cjbonn
Copy link
Contributor

@cjbonn cjbonn commented May 3, 2023

fixes #1226

The same issue was replicated across 24 files, which this PR covers.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 3, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cjbonn / name: Christopher Bonnell (a090807)

mgol
mgol approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mgol mgol changed the title Doc Example Typos fixed All: Fix button selectors May 3, 2023
@mgol mgol merged commit a71164b into jquery:main May 3, 2023
@mgol
Copy link
Member

mgol commented May 3, 2023

Thanks! The stage site should be fixed now (see e.g. http://stage.api.jquery.com/removeattr/), the main one will get fixed once someone pushes a tag - which might be me in a few days.

@cjbonn cjbonn deleted the cb/doc-example-fix branch May 3, 2023 21:44
mgol pushed a commit that referenced this pull request May 4, 2023
@cjbonn
All: Fix event selectors
21e1958 
Multiple selectors erroneously used `selector)` instead of `selector`.
This has been fixed.

The typos were accidentally introduced during
a mass-replace in gh-1223.

Fixes gh-1228
Closes gh-1229
Ref gh-1223
Ref gh-1226
Ref gh-1227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgol mgol mgol approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in .removeAttr() example

2 participants

@cjbonn @mgol