Skip to content

Offset: Be more precise about the origins for .offset() and .position() #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gibson042 merged 2 commits into from
Apr 25, 2017
Merged

Offset: Be more precise about the origins for .offset() and .position() #1027

gibson042 merged 2 commits into from
Apr 25, 2017

Conversation

@gibson042
Copy link
Member

@gibson042 gibson042 commented Mar 20, 2017

@gibson042 gibson042 mentioned this pull request Mar 20, 2017
Merged
4 tasks
@gibson042
Copy link
Member Author

gibson042 commented Apr 24, 2017

This is good to go, but I'm not sure about the api.jquery.com process. Should I bump the package.json version? And will it deploy automatically?

@kswedberg
Copy link
Member

kswedberg commented Apr 24, 2017

Hey @gibson042!
Yeah, bump the package.json version, and commit the new tag. It should deploy automatically.

@mgol
Copy link
Member

mgol commented Apr 24, 2017

Basically, once you commit all the changes invoke npm version patch & push the branch with tags.

@gibson042 gibson042 merged commit 28884e3 into jquery:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgol mgol mgol approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gibson042 @kswedberg @mgol