Skip to content

Clarify and correct .closest() docs #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmethvin opened this issue Jan 4, 2016 · 1 comment
Closed

Clarify and correct .closest() docs #857

dmethvin opened this issue Jan 4, 2016 · 1 comment
Assignees
@AurelioDeRosa

Comments

@dmethvin
Copy link
Member

dmethvin commented Jan 4, 2016

jquery/jquery#2796

Remove reference to this.context ("context of the jQuery set") since it has been deprecated and was removed in 3.0.

Clarify that the context argument is used for jQuery-extension positional selectors such as :first and nth() but otherwise only for deciding how far up the tree to stop comparing nodes . That is, the context is not used as the root for matching the selector.
@timmywil timmywil mentioned this issue Jan 11, 2016
Closed
@gibson042
Copy link
Member

Clarify that the context argument is used for jQuery-extension positional selectors such as :first and nth() but otherwise only for deciding how far up the tree to stop comparing nodes . That is, the context is not used as the root for matching the selector.

I'd like to take a different tack and ensure that positionals never match, in which case this issue is satisfied by removing the "If no context is passed in…" sentence.

AurelioDeRosa added a commit to AurelioDeRosa/api.jquery.com that referenced this issue Jan 18, 2016
@AurelioDeRosa
jQuery.closest: Removed reference to deprecated context property
4f38c08 
Fixes jquerygh-857
@AurelioDeRosa AurelioDeRosa mentioned this issue Jan 18, 2016
Closed
@AurelioDeRosa AurelioDeRosa self-assigned this Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurelioDeRosa AurelioDeRosa

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmethvin @gibson042 @AurelioDeRosa