Fix CHISEL_KEY environment variable ignored when --keyfile not set #571
+67
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CHISEL_KEYenvironment variable was being ignored when the--keyfileflag was not provided, causing the server to generate random keys on each startup instead of using the consistent key from the environment variable.Problem
The issue was in the conditional logic in
main.golines 238-242:With this logic:
--keyfileis not set, check forCHISEL_KEY_FILEenvironment variableCHISEL_KEY_FILEis also empty, then check forCHISEL_KEYThis meant
CHISEL_KEYwas never checked when--keyfilewasn't provided.Reproduction
Before the fix:
Solution
Changed the
else ifto a separateifstatement, making the environment variable checks independent:Verification
After the fix:
The fix preserves all existing behavior:
CHISEL_KEY_FILEstill takes precedence overCHISEL_KEYwhen both are set--keyfileflag still works as expected--keyflag still works (with deprecation warning)Added comprehensive tests to prevent regression of this issue.
Fixes #570.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.