add supports for chisel-key format #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jpillora
reviewed
Aug 16, 2023
share/ccrypto/keys_helpers.go
Outdated
| } | ||
|
|
||
| func IsChiselKey(chiselKey []byte) bool { | ||
| return string(chiselKey[:len(ChiselKeyPrefix)]) == ChiselKeyPrefix |
Owner
There was a problem hiding this comment.
This can be strings.HasPrefix
also, are key lengths static? Can we also check total length here?
Contributor
Author
There was a problem hiding this comment.
Not sure if the length is static or not.
Below is the code that calculates the length. Hard to say it will be constant forever.
encodedPrivateKey := make([]byte, base64.RawStdEncoding.EncodedLen(len(b)))
Contributor
Author
There was a problem hiding this comment.
BTW, the length of encodedPrivateKey is 162, but you mentioned it's 163.
Owner
|
My bad, echo | wc, includes echo newline
I’ll try find out if it’s statically 162
…On Wed, 16 Aug 2023 at 7:57 PM cmeng ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In share/ccrypto/keys_helpers.go
<#441 (comment)>:
> + }
+
+ return x509.ParseECPrivateKey(decodedPrivateKey)
+}
+
+func ChiselKey2PEM(chiselKey []byte) ([]byte, error) {
+ privateKey, err := chiselKey2PrivateKey(chiselKey)
+ if err == nil {
+ return privateKey2PEM(privateKey)
+ }
+
+ return nil, err
+}
+
+func IsChiselKey(chiselKey []byte) bool {
+ return string(chiselKey[:len(ChiselKeyPrefix)]) == ChiselKeyPrefix
BTW, the length of encodedPrivateKey is 162, but you mentioned it's 163.
—
Reply to this email directly, view it on GitHub
<#441 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE2X45XPPHE5E372I6J2WLXVSKQPANCNFSM6AAAAAA3R6X3LI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
jpillora
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.