Skip to content

Conversation

@Alvinn8
Copy link
Contributor

@Alvinn8 Alvinn8 commented Oct 4, 2024

In 24w39a, a player wearing a carved pumpkin will not appear on maps in-game. This PR adds the same functionality to squaremap.

@jpenilla
Copy link
Owner

jpenilla commented Oct 4, 2024

This should check the map_invisibility_equipment item tag rather than for carved pumpkins specifically. And the config option could be something like player-tracker.hide.map-invisibility-equipment to make this obvious for anyone searching the Minecraft wiki and etc.

@Alvinn8
Copy link
Contributor Author

Alvinn8 commented Oct 4, 2024

Good points. Since squaremap builds against 1.21.1 this tag does not exist yet. Do you want me to mark this as a draft (or close) and have it be implemented when 1.21.2 is released instead?

@jpenilla
Copy link
Owner

jpenilla commented Oct 5, 2024

Drafting it until then sounds good. Feel free to ping me here or on Discord when it's ready.

@Alvinn8 Alvinn8 marked this pull request as draft October 5, 2024 22:10
@jpenilla
Copy link
Owner

jpenilla commented Nov 5, 2024

1.21.3 is merged to master now

@Alvinn8 Alvinn8 marked this pull request as ready for review November 12, 2024 22:20
@Alvinn8
Copy link
Contributor Author

Alvinn8 commented Nov 12, 2024

Rebased and changed to use the item tag added in 1.21.2

@jpenilla jpenilla changed the title Hide players wearing carved pumpkins Hide players wearing items tagged with MAP_INVISIBILITY_EQUIPMENT Nov 13, 2024
@jpenilla
Copy link
Owner

I've adjusted the check to work more similarly to Vanilla, if mods add baubles/etc. using this tag in the future then someone will need to open an issue and I can look into it then.

@jpenilla jpenilla merged commit 6298c9d into jpenilla:master Nov 13, 2024
@Alvinn8 Alvinn8 deleted the carved-pumpkin branch November 14, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants