Repository navigation
Modify nested detection loop - #1
Merged
Merged
Conversation
Owner
|
Changes look good and reduce duplicates. Repeating here what I mentioned to @kkoz: zarr-developers/zarr-python#715 looks to be on a trajectory to remove this heuristic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop which attempts to determine whether a zarr file is nested or not appears to loop through all chunks even after determining the "nestedness". This has caused some timout issues for us. This modified version exits once a nested or not nested chunk is found, and has also re-ordered some of the logic.