Use fixed resources for sending#80
Merged
marcomorain merged 1 commit intojoshdholtz:masterfrom Sep 23, 2016
Merged
Conversation
Collaborator
Author
|
@joshdholtz this will reduce the amount of resources used by the client. This moves processing off the async task thread pool so the Sentry client won't block the app. |
marcomorain
force-pushed
the
feature-use-executor
branch
2 times, most recently
from
9e8f92e to
4d2399a
Compare
Introduce 2 limits on the resources used. Use an Executor with a thread pool of max size 1 for sending HTTP requests to Sentry. This thread pool will use 0 threads at idle, and reduce the number of threads in use down to 0 after a minute of no exceptions. Use a fixed queue for events. A queue of up to 50 events will be queued for sending to Sentry. If more than 50 events are queued, the new events will be discarded. These two changes will add a fixed ceiling to the amount of resources the Sentry client will use on the device.
marcomorain
force-pushed
the
feature-use-executor
branch
from
4d2399a to
dde05b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce 2 limits on the resources used.
Use an Executor with a thread pool of max size 1 for sending HTTP requests
to Sentry. This thread pool will use 0 threads at idle, and reduce the
number of threads in use down to 0 after a minute of no exceptions.
Use a fixed queue for events. A queue of up to 50 events will be queued
for sending to Sentry. If more than 50 events are queued, the new events
will be discarded.
These two changes will add a fixed ceiling to the amount of resources the
Sentry client will use on the device.