Enable Sentry Release tracking by default#78
Merged
marcomorain merged 1 commit intojoshdholtz:masterfrom Sep 23, 2016
Merged
Conversation
marcomorain
commented
Sep 18, 2016
| return new File(context.getCacheDir(), "crashes"); | ||
| } | ||
|
|
||
| private static String getStackTrace(Throwable t) { |
Collaborator
Author
There was a problem hiding this comment.
~ this was unused
Collaborator
Author
|
I like this one @joshdholtz :) |
marcomorain
force-pushed
the
feature-package-version
branch
2 times, most recently
from
0e29610 to
a28bbc9
Compare
If events have a 'release' attribute set, then Sentry will automcatiically the first and last release in which events occured. This change makes the client read the package's versionCode and use that as the 'release' by default. The versionCode is an integer that increases, and therefore is a perfect candidate for release tracking. The user can continue to use an event capture listener to set the release manaully, which will override this new default value. Fixes joshdholtz#71
marcomorain
force-pushed
the
feature-package-version
branch
from
a28bbc9 to
a9d792e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If events have a 'release' attribute set, then Sentry will
automcatiically the first and last release in which events occured.
This change makes the client read the package's versionCode and use that
as the 'release' by default. The versionCode is an integer that
increases, and therefore is a perfect candidate for release tracking.
The user can continue to use an event capture listener to set the
release manaully, which will override this new default value.
Fixes #71