Allow the user to specify a message with exceptions#77
Merged
marcomorain merged 2 commits intojoshdholtz:masterfrom Sep 23, 2016
Merged
Allow the user to specify a message with exceptions#77marcomorain merged 2 commits intojoshdholtz:masterfrom
marcomorain merged 2 commits intojoshdholtz:masterfrom
Conversation
It is often useful to add a string of context along with
and exception. This helps show the user what was happening
when the exception occured.
Use case:
try {
// network operation to load cats
} catch (HttpException e) {
Sentry.captureException(e, "Error loading cats");
}
marcomorain
force-pushed
the
feature-allow-message
branch
from
11fecd2 to
07b84c7
Compare
marcomorain
commented
Sep 16, 2016
| static final String isInternalPackage = "^(java|android|com\\.android|com\\.google\\.android|dalvik\\.system)\\..*"; | ||
|
|
||
| private final static SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss"); | ||
| private final static SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss", Locale.US); |
Collaborator
Author
There was a problem hiding this comment.
~ this fixes a warning in AndroidStudio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is often useful to add a string of context along with
an exception. This helps show the user what was happening
when the exception occurred.
Use case: