Fix unicode color diff.#93
Merged
josephburnett merged 1 commit intojosephburnett:masterfrom Mar 27, 2025
Merged
Conversation
The character-level color diff introduced in a907909 breaks for unicode characters. Fix this by processing strings as runes instead of bytes. Add a regression test.
Owner
|
Nice catch @roberthoenig |
Owner
|
Released as v2.2.2 |
Owner
|
@roberthoenig I added color diffs to the fuzz testing which also would have caught this bug. And the fuzzing found another bug too with escaping some ASCII characters! To find this bug I dove into the details of Go's JSON serialization logic for strings. It was much more complex than I expected! Just FYI in case you're interested. |
Contributor
Author
|
@josephburnett interesting, thanks for sharing and for fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The character-level color diff introduced in a907909 breaks for unicode characters. Fix this by processing strings as runes instead of bytes. Add a regression test.