Skip to content

Commit bb06c65

Browse files
committed
fix an issue
1 parent 4fa0d73 commit bb06c65

4 files changed

Lines changed: 3 additions & 19 deletions

File tree

__tests__/distributors/base-installer.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,7 @@ describe('normalizeVersion', () => {
312312
['11.0', { version: '11.0', stable: true }],
313313
['11.0.10', { version: '11.0.10', stable: true }],
314314
['11-ea', { version: '11', stable: false }],
315-
['11.0.2-ea', { version: '11.0.2', stable: false }],
316-
['17.0.0-beta', { version: '17.0.0', stable: false }],
317-
['17.0.0-beta+33.0', { version: '17.0.0+33.0', stable: false }]
315+
['11.0.2-ea', { version: '11.0.2', stable: false }]
318316
])('normalizeVersion from %s to %s', (input, expected) => {
319317
expect(DummyJavaBase.prototype.normalizeVersion.call(null, input)).toEqual(expected);
320318
});

dist/setup/index.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4068,15 +4068,6 @@ class JavaBase {
40684068
version = version.replace('-ea.', '+');
40694069
stable = false;
40704070
}
4071-
else if (version.endsWith('-beta')) {
4072-
version = version.replace(/-beta$/, '');
4073-
stable = false;
4074-
}
4075-
else if (version.includes('-beta+')) {
4076-
// transform '11.0.0-beta+33' -> '11.0.3+33'
4077-
version = version.replace('-beta', '');
4078-
stable = false;
4079-
}
40804071
if (!semver_1.default.validRange(version)) {
40814072
throw new Error(`The string '${version}' is not valid SemVer notation for a Java version. Please check README file for code snippets and more detailed information`);
40824073
}
@@ -39946,6 +39937,7 @@ class TemurinDistribution extends base_installer_1.JavaBase {
3994639937
const availableVersionsWithBinaries = availableVersionsRaw
3994739938
.filter(item => item.binaries.length > 0)
3994839939
.map(item => {
39940+
// normalize 17.0.0-beta+33.0.202107301459 to 17.0.0+33.0.202107301459 for earlier access versions
3994939941
const formattedVersion = this.stable
3995039942
? item.version_data.semver
3995139943
: item.version_data.semver.replace('-beta+', '+');

src/distributions/base-installer.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,6 @@ export abstract class JavaBase {
127127
// transform '11.0.3-ea.2' -> '11.0.3+2'
128128
version = version.replace('-ea.', '+');
129129
stable = false;
130-
} else if (version.endsWith('-beta')) {
131-
version = version.replace(/-beta$/, '');
132-
stable = false;
133-
} else if (version.includes('-beta+')) {
134-
// transform '11.0.0-beta+33' -> '11.0.3+33'
135-
version = version.replace('-beta', '');
136-
stable = false;
137130
}
138131

139132
if (!semver.validRange(version)) {

src/distributions/temurin/installer.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export class TemurinDistribution extends JavaBase {
2727
const availableVersionsWithBinaries = availableVersionsRaw
2828
.filter(item => item.binaries.length > 0)
2929
.map(item => {
30+
// normalize 17.0.0-beta+33.0.202107301459 to 17.0.0+33.0.202107301459 for earlier access versions
3031
const formattedVersion = this.stable
3132
? item.version_data.semver
3233
: item.version_data.semver.replace('-beta+', '+');

0 commit comments

Comments
 (0)