Skip to content

"Diff too large" message is unnecessarily alarming #27

@waldyrious

Description

@waldyrious

When a diff is larger than the currently configured limit, the error message is scarier than necessary IMO:

Image

  1. The icon should not be one of max severity error (❗), but one of mid severity warning (⚠️)
  2. The message says the diff is "too large to be previewed", suggesting a technical limitation, but in fact it's a configuration one. A more accurate wording would be "This diff exceeds the configured maximum for automatic display" or something of the sort. In fact, even just "This diff is very large" would work better.

Additionally, if I select the load anyway option, I then see a second warning:

Image

Honestly, as a user I'd expect to see this coupled with the first one, rather than having to click "show anyway" a second time. (Btw, this error should also use an icon suggesting a lower severity. I like the text, though.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions