remove literal generic type parameters of Can*#487
Merged
Conversation
jorenham
changed the title
Can*
Owner
Author
|
This doesn't seem to cause any issues for scipy-stubs, so in it goes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following protocols are no longer generic:
CanBytesCanStrCanIndexCanReprCanFormatCanDelattrCanLenCanLengthHintCanBufferAdditionally,
CanGetattr,CanSetattr, andCanSetNamehad their first genericstr-bound type parameter removed, so that now accept a single type arugment.Similarly, this removes the last type-parameter of the
CanContainsandCanSequenceprotocols.These changes were made because passing
Literals as generic type arguments almost never works as intended in practice. One excpetion isCanBool, which has some use-cases, and is therefore left as a generic type.