[IMPROVEMENT] Upgrade gradle's required version #32

Activity

1. henryx

   added

   enhancementNew feature or requestNew feature or request

   on Apr 28, 2023
2. kLeZ commented on Apr 29, 2023

   

   kLeZ

   on Apr 29, 2023

   More actions

   Trying to help on this. Just forked.
3. HomeOfTheWizard commented on Jun 8, 2023

   

   HomeOfTheWizard

   on Jun 8, 2023

   Last edited by HomeOfTheWizard

   More actions

   Hi @henryx ,

   I have created the following PR #39, a minimum work just to unblock #22.

   Tested the unitTest all is working, however I realized that 3 integrationTests don't pass with the latest version of the Vault image because the API returns 204 instead of 200.
   I did not change the tests in case you use a specific version of the image in your CI environment.

   io.github.jopenlibs.vault.api.AuthBackendPkiTests > testRevocation FAILED
       junit.framework.AssertionFailedError at AuthBackendPkiTests.java:168
   io.github.jopenlibs.vault.api.AuthBackendPkiTests > testIssueCredential FAILED
       junit.framework.AssertionFailedError at AuthBackendPkiTests.java:100
   io.github.jopenlibs.vault.api.AuthBackendPkiTests > testIssueCredentialWithCsr FAILED
       junit.framework.AssertionFailedError at AuthBackendPkiTests.java:141
   

   But I think we must fix them and alway run the tests with the latest image of Vault.

   @kLeZ please continue feel free to continue your work in case you see other improvements or changes related to the new APIs of gradle. I am new to gradle so I may have missed some things.
4. henryx commented on Jun 15, 2023

   

   henryx

   on Jun 15, 2023

   CollaboratorAuthor

   More actions

   @HomeOfTheWizard Thank you so much for you PR, I've merged it in mainline before check the CI result
5. henryx

   closed this as completedon Jun 15, 2023