Set --experimental_action_listeners to default in exec config

fmeum · copybara-github · commit 28d2daae70be · 2022-12-05T19:12:40.000-08:00
Previously, the flag value was set to `null` rather than an empty list, which resulted in distinct yet equivalent configurations. Fixes bazelbuild#16911 Closes bazelbuild#16912. PiperOrigin-RevId: 493175302 Change-Id: I7a34c988265f3a3d94f1720a7fc7ad501eb44247
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationValue.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationValue.java
@@ -17,7 +17,6 @@
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Suppliers;
 import com.google.common.collect.ImmutableCollection;
-import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.ImmutableSortedMap;
@@ -746,7 +745,7 @@ public int analysisTestingDepsLimit() {
   }
 
   public List<Label> getActionListeners() {
-    return options.actionListeners == null ? ImmutableList.of() : options.actionListeners;
+    return options.actionListeners;
   }
 
   /**
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/ExecutionTransitionFactory.java b/src/main/java/com/google/devtools/build/lib/analysis/config/ExecutionTransitionFactory.java
@@ -129,7 +129,7 @@ private static BuildOptions transitionImpl(BuildOptionsView options, Label execu
       coreOptions.isHost = false;
       coreOptions.isExec = true;
       // Disable extra actions
-      coreOptions.actionListeners = null;
+      coreOptions.actionListeners = ImmutableList.of();
 
       // Then set the target to the saved execution platform if there is one.
       PlatformOptions platformOptions = execOptions.get(PlatformOptions.class);

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`import com.google.common.annotations.VisibleForTesting;`
`18`	`18`	`import com.google.common.base.Suppliers;`
`19`	`19`	`import com.google.common.collect.ImmutableCollection;`
`20`		`-import com.google.common.collect.ImmutableList;`
`21`	`20`	`import com.google.common.collect.ImmutableMap;`
`22`	`21`	`import com.google.common.collect.ImmutableSet;`
`23`	`22`	`import com.google.common.collect.ImmutableSortedMap;`
`@@ -746,7 +745,7 @@ public int analysisTestingDepsLimit() {`
`746`	`745`	`}`
`747`	`746`
`748`	`747`	`public List<Label> getActionListeners() {`
`749`		`- return options.actionListeners == null ? ImmutableList.of() : options.actionListeners;`
	`748`	`+ return options.actionListeners;`
`750`	`749`	`}`
`751`	`750`
`752`	`751`	`/**`