Acceptance test: Extract boilerplate networking

jonreid · jonreid · commit 53dee4d6b445 · 2015-07-19T09:46:03.000-07:00
diff --git a/MarvelBrowser/QCOMarvelAuthenticationAcceptanceTests.m b/MarvelBrowser/QCOMarvelAuthenticationAcceptanceTests.m
@@ -21,18 +21,24 @@ - (void)testValidCallToMarvel_ShouldGetHTTPStatusCode200
     NSURL *validQueryURL = [NSURL URLWithString:
             [validQueryMissingAuthentication stringByAppendingString:[authentication URLParameters]]];
 
+    __block NSHTTPURLResponse *httpResponse;
+    [self startGETRequestToURL:validQueryURL
+         withCompletionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
+             httpResponse = (NSHTTPURLResponse *)response;
+         }];
+
+    assertThatAfter(5, futureValueOf(@(httpResponse.statusCode)), is(@200));
+}
+
+- (void)startGETRequestToURL:(NSURL *)url
+       withCompletionHandler:(void (^)(NSData *, NSURLResponse *, NSError *))completionHandler
+{
     NSURLSessionConfiguration *sessionConfig = [NSURLSessionConfiguration defaultSessionConfiguration];
     NSURLSession *session = [NSURLSession sessionWithConfiguration:sessionConfig
                                                           delegate:nil
                                                      delegateQueue:nil];
-    __block NSHTTPURLResponse *httpResponse;
-    NSURLSessionDataTask *dataTask = [session dataTaskWithURL:validQueryURL
-                                            completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
-                                                httpResponse = (NSHTTPURLResponse *)response;
-                                            }];
+    NSURLSessionDataTask *dataTask = [session dataTaskWithURL:url completionHandler:completionHandler];
     [dataTask resume];
-
-    assertThatAfter(5, futureValueOf(@(httpResponse.statusCode)), is(@200));
 }
 
 @end
