Skip to content

Zeppelin 2057#6

Closed
jongyoul wants to merge 5 commits intomasterfrom
ZEPPELIN-2057
Closed

Zeppelin 2057#6
jongyoul wants to merge 5 commits intomasterfrom
ZEPPELIN-2057

Conversation

@jongyoul
Copy link
Copy Markdown
Owner

What is this PR for?

A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html

What type of PR is it?

[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Outline the steps to test the PR here.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@jongyoul jongyoul closed this Feb 13, 2017
jongyoul pushed a commit that referenced this pull request Feb 7, 2024
### What is this PR for?
Recreation of apache#1354
This PR is bringing Contribution guidelines to the website.
We also introduce a sidemenu on those pages allowing to create additional content.
As an example, for the Web Application Guidelines, we added a page about "Defining Components"

In a different PR, we will remove the contributing markdown, and change the links in the repository to the website.

The layout of the doc was slightly modified to allow a larger documentation at max size.
It was also modified to accommodate better on smaller screens.

### What type of PR is it?
Documentation

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1346

### How should this be tested?
Build the website locally and visit the community page

### Screenshots (if appropriate)
![screen shot 2016-08-23 at 3 50 41 pm](https://cloud.githubusercontent.com/assets/710411/17882774/8da96b86-6949-11e6-8789-fed606b64fd8.png)

<img width="1346" alt="screen shot 2016-08-31 at 10 33 36 am" src="https://cloud.githubusercontent.com/assets/710411/18113150/7bb2a152-6f68-11e6-8678-667c2d4f07ef.png">

#### Layout update (Before / After)

Navbar Bug fix

<img width="908" alt="screen shot 2016-08-31 at 10 35 14 am" src="https://cloud.githubusercontent.com/assets/710411/18113174/a374ee84-6f68-11e6-8878-a8eb7b564bd7.png">

<img width="781" alt="screen shot 2016-08-31 at 10 31 18 am" src="https://cloud.githubusercontent.com/assets/710411/18113161/9a280b0e-6f68-11e6-8dc5-1656b5bc86b1.png">

Small Device Margin Improvement

<img width="402" alt="screen shot 2016-08-31 at 10 35 34 am" src="https://cloud.githubusercontent.com/assets/710411/18113176/a590f74e-6f68-11e6-8468-18274413be28.png">

<img width="398" alt="screen shot 2016-08-31 at 10 31 28 am" src="https://cloud.githubusercontent.com/assets/710411/18113168/9e904d5a-6f68-11e6-9a2e-2536cbf7a37f.png">

Content Width Change

<img width="953" alt="screen shot 2016-08-31 at 10 33 50 am" src="https://cloud.githubusercontent.com/assets/710411/18113180/a7fc954c-6f68-11e6-8d58-08afb54549c1.png">

<img width="1023" alt="screen shot 2016-08-31 at 10 32 12 am" src="https://cloud.githubusercontent.com/assets/710411/18113169/a0d71aee-6f68-11e6-8654-3f124bd2a71b.png">

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Damien CORNEAU <[email protected]>
Author: AhyoungRyu <[email protected]>
Author: CORNEAU Damien <[email protected]>

Closes apache#1356 from corneadoug/add/ContributeCategory and squashes the following commits:

1a45b92 [Damien CORNEAU] Improve margin for small devices
9169c68 [Damien CORNEAU] Improve wording and spacing in contribution docs
d31cf3f [Damien CORNEAU] Improve CSS for the content
a469d52 [Damien CORNEAU] Extend pages_list to support multi group
79d15a3 [Damien CORNEAU] Add Contribution Guidelines to SubMenu
934afd9 [Damien CORNEAU] Change Zeppelin to Apache Zeppelin in general.md
2d62d20 [CORNEAU Damien] Merge pull request #6 from AhyoungRyu/add/ContributeCategory-ahyoung
e34fc64 [Damien CORNEAU] fix typo in front-end doc
a4c924b [AhyoungRyu] Remove 'menu' property
e0b4c8d [Damien CORNEAU] change name of good practice file
9882670 [Damien CORNEAU] Allows contribution page without side Menu
318c4c1 [AhyoungRyu] Add section for 'For committers only'
8f69f28 [Damien CORNEAU] Add GUI integration tests CLI
e7209ea [AhyoungRyu] Add docs contribution guide
94d653b [Damien CORNEAU] Fix typos
81493ab [Damien CORNEAU] Change Side Menu style
666f3ec [Damien CORNEAU] Add first Zeppelin-web best practices page
306ae06 [Damien CORNEAU] Add zeppelin-web GPG menu
c933c19 [Damien CORNEAU] Add zeppelin-web contribution page
5f7e2bd [Damien CORNEAU] Add a side menu template
acc68b5 [Damien CORNEAU] Add contribution Guidelines to the website
cb87608 [Damien CORNEAU] Add forgotten license headers
06238fb [Damien CORNEAU] Modify the Community page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant