Ship release Rust workers in direct distribution bundle#52
Merged
Conversation
Add build-rust-release to compile workers with cargo --release and copy them into .build/release/. bundle-direct now depends on it and copies voicey-capture, voicey-fetch, and voicey-supervisor into Voicey.app/Contents/MacOS/. sign-direct and scripts/release.sh codesign those worker binaries after mlx.metallib and before the main app, which is required for notarization.
jonathanKingston
marked this pull request as ready for review
May 27, 2026 22:47
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release builds (
make bundle-direct/make ship-release) previously shipped only the Swift app and Sparkle, while debug bundles already included the Rust multiprocess runtime workers. This closes that gap so 1.6+ releases include the sandboxed workers by default.Changes
build-rust-release— runscargo build --release, verifies all three workers exist, and copies them to.build/release/.bundle-direct— now depends onbuild-rust-releaseand copiesvoicey-capture,voicey-fetch, andvoicey-supervisorintoVoicey.app/Contents/MacOS/(fails fast if any worker is missing).sign-direct— codesigns worker binaries aftermlx.metalliband before the main app (required for notarization).scripts/release.sh— same worker codesign step in the release signing path.Debug workflows (
build-rust,bundle-debug,bundle-debug-direct) are unchanged.Test plan
make build-rust-releaseproducestarget/release/{voicey-capture,voicey-fetch,voicey-supervisor}make bundle-directcopies release workers intoVoicey.app/Contents/MacOS/make sign-direct DEVELOPER_ID=...codesigns workers before the main appcodesign --verify --deep --strict Voicey.apppasses with workers presentmake ship-release VERSION=...(or./scripts/release.sh ...) notarizes successfullyCannot verify build/sign/notarize on Linux Cloud Agent (macOS-only toolchain).