Add automated version bumping script for plist files#4
Merged
Conversation
CFBundleVersion was stuck at "1" while the appcast uses the marketing version (e.g. "1.1.1") in sparkle:version. Sparkle compares these two values to decide if an update is available, so it always saw "1.1.1" > "1" and re-offered the same download — even after the user already installed the update. Sync CFBundleVersion with CFBundleShortVersionString in both plists. https://claude.ai/code/session_012XtbEGjyQCfrYqwnfuMRcs
Introduces scripts/bump-version.sh which sets both CFBundleVersion and CFBundleShortVersionString in all plist files, preventing the mismatch that caused Sparkle to loop on download modals. The release script now calls bump-version.sh automatically so the plists are always in sync with the release version. https://claude.ai/code/session_012XtbEGjyQCfrYqwnfuMRcs
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an automated version bumping workflow to keep CFBundleShortVersionString and CFBundleVersion in sync across all plist files during releases.
Key Changes
New script:
scripts/bump-version.sh- Automates updating version strings in plist filesInfo.plistandInfo.direct.plistUpdated release workflow:
scripts/release.shnow calls the bump-version script before buildingSynchronized plist files: Both
Info.plistandInfo.direct.plistnow have matching CFBundleVersion values (1.1.1)Implementation Details
PlistBuddyutility for safe plist modificationshttps://claude.ai/code/session_012XtbEGjyQCfrYqwnfuMRcs