(Android) Fix multi-byte UTF-8 issue : Translating the non english language data properly #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadafk831
changed the title
sadafk831
changed the title
Author
|
@Traviskn would be great if I can get a quick review on this as this looks like a road blocker for us. |
|
Thank you for this PR, apologies for the slow review |
|
Thanks for taking this one on @sadafk831 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
Purpose of the PR
We are having this issue for all our
Arabicdata received from the server as that data gets converted to some gibberish data after we use RNFetchBlob fetch asThe proposed changes fix the issue, and again we can see the Arabic content as supposed to be.
How did I tested
if/elsecondition which made the base64 crash, I added that check also in this PR.