Update views.* endpoints to use POST method instead of GET#146
Merged
damienalexandre merged 2 commits intojolicode:mainfrom Mar 30, 2022
matthewnessworthy:view-post
Merged
Update views.* endpoints to use POST method instead of GET#146damienalexandre merged 2 commits intojolicode:mainfrom matthewnessworthy:view-post
damienalexandre merged 2 commits intojolicode:mainfrom
matthewnessworthy:view-post
Conversation
Contributor
Author
|
@damienalexandre please review |
damienalexandre
requested changes
Mar 30, 2022
pyrech
approved these changes
Mar 30, 2022
Member
|
#147 has been merged, you have to rebuild this PR from "main". Sorry about that 😋 |
Contributor
Author
|
@damienalexandre no worries, all done |
damienalexandre
requested changes
Mar 30, 2022
Member
damienalexandre
left a comment
damienalexandre
left a comment
There was a problem hiding this comment.
The method on viewPublish/viewPush/viewUpdate is still "GET" but the parameters have been changed to "form parameter", am I missing something? viewOpen looks good.
damienalexandre
approved these changes
Mar 30, 2022
Member
|
Thanks a lot! |
damienalexandre
added a commit
that referenced
this pull request
Mar 30, 2022
Contributor
Author
|
Glad i could help, thanks for the support and hand-holding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
Replaces #130 (because of merge conflicts)
First updated the SDK with the latest updates
Then after updating the relevant HTTP methods in
resources/slack-openapi-patched.json