Skip to content

feat: ability to select jar when unlocking fidelity bond (#574)#885

Merged
theborakompanioni merged 4 commits intojoinmarket-webui:develfrom
nischal-shetty2:feat/select-jar
Apr 18, 2025
Merged

feat: ability to select jar when unlocking fidelity bond (#574)#885
theborakompanioni merged 4 commits intojoinmarket-webui:develfrom
nischal-shetty2:feat/select-jar

Conversation

@nischal-shetty2
Copy link
Contributor

Fixes #574

When unlocking fidelity bonds, the user can now select the destination jar for the unlocked funds from the accordion (Which is initially closed and will have selected the Jar A by default)

WhatsApp.Video.2025-04-10.at.19.55.04.1.mp4

@nischal-shetty2
Copy link
Contributor Author

Hey @theborakompanioni @editwentyone what do you think about this? The issue had been pending for a while, so I thought I’d pick it up.

@theborakompanioni
Copy link
Collaborator

Nice! Can you fix the CI errors? I'll take a look soon! 🚀

@nischal-shetty2
Copy link
Contributor Author

Can you fix the CI errors?

Pushed the fix @theborakompanioni

I'll take a look soon! 🚀

Sure!

@theborakompanioni
Copy link
Collaborator

Can you fix the CI errors?

Pushed the fix @theborakompanioni

I'll take a look soon! 🚀

Sure!

I have moved the jar selection back from PaymentConfirmModal to SpendFidelityBondModal. Looks good to me! Can you look over the changes once again? Otherwise, it is ready to merge 🚀

Waiting for your feedback. Thank you @nischal-shetty2 🙏

@theborakompanioni theborakompanioni self-requested a review April 16, 2025 19:52
@nischal-shetty2
Copy link
Contributor Author

I have moved the jar selection back from PaymentConfirmModal to SpendFidelityBondModal.

Yes this was the right move actually @theborakompanioni , looks good to me! This can be merged!

@theborakompanioni theborakompanioni merged commit 1f2acd2 into joinmarket-webui:devel Apr 18, 2025
1 check passed
@nischal-shetty2 nischal-shetty2 deleted the feat/select-jar branch April 18, 2025 11:59
@editwentyone
Copy link

awesome work. keep it up :)

@theborakompanioni
Copy link
Collaborator

Thanks @nischal-shetty2 🙏

@nischal-shetty2
Copy link
Contributor Author

Thank you so much @theborakompanioni @editwentyone ! I'm participating in Summer of Bitcoin this year with JAM, and I hope to be an intern on this project. But even if I don't make it, I'll still continue to be a part of JAM regardless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: ability to select jar when unlocking fidelity bond

3 participants