chore(i18n): update splashscreen_warning_text: improve english#867
Merged
MarnixCroes merged 1 commit intojoinmarket-webui:develfrom Oct 31, 2024
Merged
chore(i18n): update splashscreen_warning_text: improve english#867MarnixCroes merged 1 commit intojoinmarket-webui:develfrom
MarnixCroes merged 1 commit intojoinmarket-webui:develfrom
Conversation
theborakompanioni
added
the
i18n
theborakompanioni
approved these changes
Oct 31, 2024
theborakompanioni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bit of a nit
"Jam is anything but" is not good English afaik.
so change the text to
Jam is not, to match other places where it is mentioned:jam/src/components/Onboarding.tsx
Line 82 in 66a100d
jam/src/i18n/locales/en/translation.json
Line 54 in 66a100d