Skip to content

build: update node version#866

Merged
theborakompanioni merged 2 commits intodevelfrom
chore/update-node-version
Oct 31, 2024
Merged

build: update node version#866
theborakompanioni merged 2 commits intodevelfrom
chore/update-node-version

Conversation

@theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Oct 31, 2024

Updates required node version from v16.11.0 to v22.11.0.

If you are running a version lower than v22.11.0, you will see the following error:

> node -v
v20.10.0
> npm i
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Required: {"node":">=22.11.0","npm":">=10.9.0"}
npm ERR! notsup Actual:   {"npm":"10.2.3","node":"v20.10.0"}

Install supported node version:

> nvm use
Found './.nvmrc' with version <v22.11.0>
Now using node v22.11.0 (npm v10.9.0)
> node --version
v22.11.0
> npm --version
10.9.0

@theborakompanioni theborakompanioni added dependencies Pull requests that update a dependency file devtools Improvements in tooling labels Oct 31, 2024
@theborakompanioni theborakompanioni self-assigned this Oct 31, 2024
@theborakompanioni theborakompanioni marked this pull request as ready for review October 31, 2024 07:09
This was referenced Oct 31, 2024
Closed
Merged
MarnixCroes
MarnixCroes approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 91a5e56

@theborakompanioni theborakompanioni merged commit 72d2c7d into devel Oct 31, 2024
@theborakompanioni theborakompanioni deleted the chore/update-node-version branch October 31, 2024 09:00
bhaveshg16 pushed a commit to bhaveshg16/jam that referenced this pull request Nov 2, 2024
@theborakompanioni @bhaveshg16
build: update node version (joinmarket-webui#866)
24cfa9f 
* build(deps): require node >=v22.11.0

* chore(build): add .nvmrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarnixCroes MarnixCroes MarnixCroes approved these changes

@editwentyone editwentyone Awaiting requested review from editwentyone

@bhaveshg16 bhaveshg16 Awaiting requested review from bhaveshg16

@amitx13 amitx13 Awaiting requested review from amitx13

Assignees

@theborakompanioni theborakompanioni

Labels

dependencies Pull requests that update a dependency file devtools Improvements in tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theborakompanioni @MarnixCroes