Skip to content

fix: relative fee greater than zero#862

Merged
theborakompanioni merged 7 commits intodevelfrom
fix/relative-fee-greater-than-zero
Oct 31, 2024
Merged

fix: relative fee greater than zero#862
theborakompanioni merged 7 commits intodevelfrom
fix/relative-fee-greater-than-zero

Conversation

@theborakompanioni
Copy link
Collaborator

Resolves #861.

Before this commit, attempting to create a relative offer with zero fees resulted in the backend crashing.
After this commit, a user must input a value greater than zero to start a maker.

@theborakompanioni theborakompanioni added the bug Something isn't working label Oct 30, 2024
@theborakompanioni theborakompanioni self-assigned this Oct 30, 2024
@theborakompanioni theborakompanioni force-pushed the fix/relative-fee-greater-than-zero branch from a2cbc66 to 9711dde Compare October 30, 2024 15:49
@theborakompanioni theborakompanioni marked this pull request as ready for review October 31, 2024 09:04
@theborakompanioni theborakompanioni merged commit 5c3306b into devel Oct 31, 2024
@theborakompanioni theborakompanioni deleted the fix/relative-fee-greater-than-zero branch October 31, 2024 13:23
bhaveshg16 pushed a commit to bhaveshg16/jam that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: zero relative maker fee crashes backend

2 participants