Skip to content

Refactor and DRYer code#821

Merged
theborakompanioni merged 15 commits intodevelfrom
796-ui-confirmation-modal-before-starting
Aug 28, 2024
Merged

Refactor and DRYer code#821
theborakompanioni merged 15 commits intodevelfrom
796-ui-confirmation-modal-before-starting

Conversation

@0xSaksham
Copy link
Contributor

Implemented the Suggested changes

  • Removed Start Scheduler Button
  • Refactored code using already available ConfirmModal
  • Removed CSS files, not needed

Future Goals

  • Make it localized

@0xSaksham 0xSaksham self-assigned this Aug 24, 2024
@0xSaksham 0xSaksham added the refactoring Code refactoring without functional changes label Aug 24, 2024
@0xSaksham 0xSaksham added this to the SoB milestone Aug 24, 2024
@0xSaksham
Copy link
Contributor Author

0xSaksham commented Aug 24, 2024

hey @theborakompanioni now this PR will block my workflow. Please review and merge it as soon as you get time.

@0xSaksham
Copy link
Contributor Author

@theborakompanioni all the changes that we talked about are done, please review this PR if you get time. Thanks!

@theborakompanioni theborakompanioni merged commit b116e77 into devel Aug 28, 2024
@theborakompanioni theborakompanioni deleted the 796-ui-confirmation-modal-before-starting branch August 28, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Code refactoring without functional changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants