refactor: align utxo list and modal components#815
Merged
theborakompanioni merged 10 commits intodevelfrom Aug 20, 2024
Merged
Conversation
6 tasks
amitx13
reviewed
Aug 20, 2024
Contributor
amitx13
left a comment
amitx13
left a comment
There was a problem hiding this comment.
Hey @theborakompanioni In dark mode, I am unable to see unfrozen UTXOs with the deposit tag, but they are clearly visible on your end. Could you please take a look and confirm? It seems everything is working correctly on my side.
Collaborator
Author
Thanks so much, @amitx13! Should be fixed now. 🙌 |
amitx13
approved these changes
Aug 20, 2024
Contributor
amitx13
left a comment
amitx13
left a comment
There was a problem hiding this comment.
Yes, everything is working fine on my end now.
Closed
0xSaksham
added a commit
that referenced
this pull request
Aug 21, 2024
* fix: amount input field to properly interpret BTC (#800) * feat: add SchedulerConfirmationModal component for starting scheduled sweep (#803) * feat: add SchedulerConfirmationModal component for starting scheduled sweep * removed dead code * modal is centered and design changes * used ConfirmModal and pre-written styles * refactor: SchedulerConfirmationModal.tsx minor production error * build(deps): update dependencies (#813) @emotion/react ^11.11.4 → ^11.13.0 @types/react ^18.3.2 → ^18.3.3 formik ^2.4.5 → ^2.4.6 qrcode ^1.5.3 → ^1.5.4 react-bootstrap ^2.9.2 → ^2.10.4 react-router-bootstrap ^0.26.2 → ^0.26.3 react-router-dom ^6.23.1 → ^6.26.1 husky ^8.0.3 → ^9.1.4 i18next ^23.11.4 → ^23.13.0 lint-staged ^14.0.1 → ^15.2.9 prettier ^3.2.5 → ^3.3.3 react-i18next ^14.1.1 → ^15.0.1 * refactor: align utxo list and modal components (#815) * refactor: externalize UtxoIcon component and utxoTags function * refactor: externalize UtxoConfirmations component * refactor: reuse utxo icons in Jar details and UTXO list * refactor(ui): simpler checkbox in utxo list * refactor(send): vertically align balance * refactor(send): tooltip for shortened addresses * refactor(ui): externalize UtxoTags component * ui(send): show considered UTXOs before performing transaction (#807) --------- Co-authored-by: apX13_ <[email protected]> Co-authored-by: Thebora Kompanioni <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #771 which introduces some UTXO related UI components that can be reused across different pages or interface elements, i.e. the UTXO list in the Jar Details View and the Quick Freeze Modal on the Send page.
Some details are subject to discussion, e.g. the color scheme and/or icons.
This is not a pixel-perfect representation of the Figma designs, but simplifies the current state and increases reusability.
Next step would be alignment and adaptation of the wording (not done in this PR).
📸