follow-up(PR771): quick freeze/unfreeze#802
Conversation
6358015 to
5372ef0
Compare
There was a problem hiding this comment.
Wow, the code looks way cleaner and has a precise approach! The improvements are really clear. I did notice a few UI-related aspects that might need some attention:
- The checkbox is too close to the border.
- The tags are positioned too close to the balance.
- The cancel button is larger than the confirm button.
- I also remember having a meeting with Edi where he mentioned that initially, only 5 UTXOs should be visible, and the rest should be scrollable.
I am nowhere near @editwentyone when it comes to UI, so I think it might be helpful if @editwentyone could take a look at the modal.
Lastly, just a thought: Previously, users were not allowed to unfreeze the last UTXO and proceed with the transaction, but now they can. Considering this change, I came across two conclusions:
- Maybe we shouldn’t restrict users from doing what they want, as they’re ultimately responsible for their actions.
- Most users tend to learn by tinkering around rather than reading documentation. So, in my opinion, we should restrict users from doing that.
What do you think?
|
Hey @amitx13! Appreciate the valuable feedback!
Changed when switching from
👍
Ha, how could I not notice that! Thanks 🥲 Edit: It's with all the buttons in modal footers -> will be fixed in a different PR.
Yes. Good idea. I am still unsure how to make it more obvious that the list is scrollable and there are more UTXOs below..
Yes, feedback from @editwentyone is highly appreciated 🙏
Like you clear thinking on this one. But yes, this is intentional, however, open for discussion. Personally, I'd go for option 1. |
|
Ready for review.. it's not yet in the shape I would like it to be, but it's better than before and should be good enough to build on. Especially the tag handling should be improved and refactored in a follow-up PR. But also some UI adaptions are still necessary. |
…gic to align with recent changes in PR #802
Yes, you are right - this is done in a follow-up PR. Can you review and add feedback for #815?
Any contribution is welcome! Best would be to focus on bringing your current PRs on |
…gic to align with recent changes in PR #802

Follow-up to #771.
TBD.
Still TODO:
ShowUtxosshould not useConfirmModal(instead use an own/new distinct modal component?)ShowUtxosrefactored to be external toSourceJarSelector?ShowUtxos->QuickFreezeUtxoModal?