feat(config): ability to customize "max sweep fee change" setting#793
Merged
theborakompanioni merged 2 commits intodevelfrom Jul 16, 2024
Merged
feat(config): ability to customize "max sweep fee change" setting#793theborakompanioni merged 2 commits intodevelfrom
theborakompanioni merged 2 commits intodevelfrom
Conversation
theborakompanioni
requested review from
0xSaksham,
amitx13,
bhaveshg16 and
editwentyone
theborakompanioni
force-pushed
the
feat/max-sweep-fee-change
branch
from
7b137f0 to
243ab88
Compare
editwentyone
approved these changes
Jul 16, 2024
|
addition: It would be nice to get this component into "send options" as soon as the user uses "Sweeps" function. so, when the user prepared everything at the top to sweep, and opens up the send options, the user would get the max sweep fee component presented as a shortcut underneath the mining fee input field |
Collaborator
Author
Great idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to customize the
max_sweep_fee_changesettings property.Part of #761. This enables loading the settings value and showing the user a maximum fee for sweeps, e.g. in the confirm dialog.
📸