Right Caret Added in Start Scheduler Button#783
Merged
theborakompanioni merged 7 commits intomasterfrom Jul 2, 2024
Merged
Conversation
0xSaksham
requested review from
amitx13,
bhaveshg16,
editwentyone and
theborakompanioni
theborakompanioni
removed request for
amitx13,
bhaveshg16,
editwentyone and
theborakompanioni
Collaborator
Hey @0xSaksham! PR has been converted to draft and reviewers removed! Please add them anytime you think the changes are ready for a review. 🙌 |
Contributor
Author
|
|
Contributor
Author
|
You have to put 3 different addresses to make the scheduler start. |
Contributor
Author
|
This is Ready to merge! |
0xSaksham
changed the title
Collaborator
Please remove everything not related to the icon change. e.g. passing |
src/components/Jam.tsx
Outdated
| setAlert(undefined) | ||
| setIsWaitingSchedulerStart(true) | ||
|
|
||
| // const destinations = addressValueKeys(addressCount).map((key) => values[key]) |
Collaborator
There was a problem hiding this comment.
Suggested change
| // const destinations = addressValueKeys(addressCount).map((key) => values[key]) |
src/components/Jam.tsx
Outdated
Comment on lines
292
to
303
| tumbler_options: { | ||
| addrcount: addressCount, | ||
| minmakercount: 1, | ||
| makercountrange: [1, 0], | ||
| mixdepthcount: addressCount, | ||
| mintxcount: 1, | ||
| txcountparams: [1, 0], | ||
| timelambda: 0.025, // 0.025 minutes := 1.5 seconds | ||
| stage1_timelambda_increase: 1.0, | ||
| liquiditywait: 13, | ||
| waittime: 0.0, | ||
| }, |
Collaborator
There was a problem hiding this comment.
Suggested change
| tumbler_options: { | |
| addrcount: addressCount, | |
| minmakercount: 1, | |
| makercountrange: [1, 0], | |
| mixdepthcount: addressCount, | |
| mintxcount: 1, | |
| txcountparams: [1, 0], | |
| timelambda: 0.025, // 0.025 minutes := 1.5 seconds | |
| stage1_timelambda_increase: 1.0, | |
| liquiditywait: 13, | |
| waittime: 0.0, | |
| }, |
src/components/Jam.tsx
Outdated
Comment on lines
356
to
359
| {' '} | ||
| { | ||
| // MARK: Scheduler Page | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| {' '} | |
| { | |
| // MARK: Scheduler Page | |
| } |
Contributor
Author
|
Completed the Changes |
theborakompanioni
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR tries to implement #319
I still need to make the scheduler run in normal mode, and work flawlessly with
npm startandnpm run dev:start