fix(fb): display error alert in modal#776
Merged
bhaveshg16 merged 1 commit intojoinmarket-webui:masterfrom Jun 4, 2024
Merged
Conversation
theborakompanioni
approved these changes
Jun 4, 2024
Collaborator
e.g. this gets triggered when the wallet is not "Fidelity Bond"-enabled, when the wallet is created via the CLI and the users presses We could load the timelocked address immediately after selecting the date, so the error would get triggered earlier in the process. Currently the user selects a UTXO and only then the address is loaded.. maybe this can be considered in #650? PR looks good! Approved 🚀 |
theborakompanioni
approved these changes
Jun 4, 2024
theborakompanioni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #775
The alert message has been shifted inside modal.
However I was not able to produce the error locally, so its requested to produce the error locally while reviewing it. and please let know if it works fine.
PS: If anyone gets to know how to produce error, I would love to learn it as well.