modal instead of dropdown for new FB creation form#762
modal instead of dropdown for new FB creation form#762bhaveshg16 merged 2 commits intojoinmarket-webui:masterfrom
Conversation
Good thinking! Imho, it is okay and better to stay consistent. Header color in light mode can be changed in a different PR, if needed! tACK. Thanks @barrytra 💪 |
amitx13
left a comment
There was a problem hiding this comment.
yup! It's working fine. Good job, @barrytra
|
Ahh!! I get it. It was actually placed initially according to dropdown. This should be fixed. |
|
Also can you suggest a way to produce this error?? |
That would probably be best, yes. Otherwise it might not be visible to the user.
You can temporarily adapt the request code and throw an error here. |




this PR fixes #760

When user clicks "configure fidelity bond" modal appears like this:
Whole flow to create new bond works fine on my setup.
Open to any kind of suggestions.
PS: Cross Button at top-right functions same as cancel button. I've kept it as it will be useful for later UI design.