chore(ui): disable lock button while locking wallet#759
Merged
theborakompanioni merged 1 commit intomasterfrom May 21, 2024
Merged
chore(ui): disable lock button while locking wallet#759theborakompanioni merged 1 commit intomasterfrom
theborakompanioni merged 1 commit intomasterfrom
Conversation
theborakompanioni
added
the
UI/UX
amitx13
approved these changes
May 21, 2024
Contributor
amitx13
left a comment
amitx13
left a comment
There was a problem hiding this comment.
Yup! There are no additional requests; everything is working fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locking the wallet can take some time (sometimes a few seconds, e.g. via Tor). This avoids additional requests being made if the button is clicked while a request is in-flight.
(It is not totally obvious in the screenshot, but the button is disabled)