feat: align amount input fields#711
Merged
theborakompanioni merged 21 commits intomasterfrom Jan 13, 2024
Merged
Conversation
theborakompanioni
force-pushed
the
feat/692-new-amount-input
branch
from
3be0841 to
d5b5a9e
Compare
Collaborator
Author
|
@editwentyone Amount input on send page has been aligned with your designs. Let me know, if this is what you had in mind. |
theborakompanioni
force-pushed
the
feat/692-new-amount-input
branch
2 times, most recently
from
5a18835 to
fe66ac2
Compare
|
I love it, it's not exactly as discussed, like the 3 dots are missing before you start typing […] but I'm sure you had your reasons to change it. I really like it as it is! just change the label above: Amount in sats » Amount |
theborakompanioni
force-pushed
the
feat/692-new-amount-input
branch
from
fe66ac2 to
efe4384
Compare
theborakompanioni
added
enhancement
Collaborator
Author
|
@editwentyone all amount inputs changed to the new "universal" input. Also adapted labels and placeholders as you suggested. Hope I did not miss anything 🙏 |
editwentyone
approved these changes
Jan 9, 2024
|
on the bitcoin symbol: 400 weight, 1.1rem |
theborakompanioni
force-pushed
the
feat/692-new-amount-input
branch
from
e3b36ce to
3ed97ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #692.
Untouched:
Input in sats (focus):
Input in sats (without focus):
Input in BTC (focus):
Input in BTC (without focus):
Errors (focus):
Errors (without focus):