Skip to content

dev(regtest): update bitcoin core to v26#710

Merged
theborakompanioni merged 1 commit intomasterfrom
dev/bitcoin-v26
Dec 20, 2023
Merged

dev(regtest): update bitcoin core to v26#710
theborakompanioni merged 1 commit intomasterfrom
dev/bitcoin-v26

Conversation

@theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Dec 13, 2023

This updates regtest Bitcoin Core from v25 to v26.

Should serve as a reminder for everyone using JM/Jam wanting to upgrade to Bitcoin Core v26: You need to add arg -deprecatedrpc=create_bdb (at start or in conf file).

See JoinMarket-Org/joinmarket-clientserver#1571 for more information.

Meta question: How will this work for users with Umbrel/Citadel/RaspiBlitz/etc.?

@theborakompanioni theborakompanioni self-assigned this Dec 13, 2023
@theborakompanioni theborakompanioni added question Further information is requested dependencies Pull requests that update a dependency file devtools Improvements in tooling labels Dec 13, 2023
@theborakompanioni theborakompanioni marked this pull request as ready for review December 13, 2023 18:07
@kristapsk
Copy link
Contributor

Meta question: How will this work for users with Umbrel/Citadel/RaspiBlitz/etc.?

They should add deprecatedrpc=create_bdb for now. People using these should review / add comments and make sure it gets added to config when upgrading to v26. Probably JM will have proper descriptor wallet support on next release, but not sure how fast we will get there.

Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK db73b4e

@theborakompanioni theborakompanioni merged commit d4466a0 into master Dec 20, 2023
@theborakompanioni theborakompanioni deleted the dev/bitcoin-v26 branch December 20, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file devtools Improvements in tooling question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants