chore(send): align unit in collaborators fee breakdown#708
chore(send): align unit in collaborators fee breakdown#708theborakompanioni merged 3 commits intomasterfrom
Conversation
theborakompanioni
added
bug
MarnixCroes
left a comment
MarnixCroes
left a comment
There was a problem hiding this comment.
ack fbc852a
Jam can still display values in sats (instead of BTC) - so the toggle will influence the displayed unit (as opposed to always show in BTC). Getting rid of the conversion to sats has been thought about, but should be done in a separate issues if needed.
do you mean getting rid of the BTC/sats option in settings in general?
for me that would be a nack, it's nice.
the thing that could be improved about this is having also the input field in BTC when unit is BTC. now those are still sats which can be annoying/confusing.
|
what about these? |
already on it : #692 |
|
tiny stuff in details view: because of the bond?
|
|
Yes. The current behaviour of the BTC unit should (theoretically) combine best of both worlds.. which would make the differentiation obsolete.. would be less code while having nearly same functionality. However, I can live with keeping it.
Yep, that is planned to be worked on soon and hopefully lands in v0.2.0. 🙌 |
|
3 participants
Resolves #707.
Shows the expected collaborator fees in the unit of the users choice.
Jam can still display values in sats (instead of BTC) - so the toggle will influence the displayed unit (as opposed to always show in BTC). Getting rid of the conversion to sats has been thought about, but should be done in a separate issues if needed.
📸